Repository navigation
Closed
Labels
initiativeEpic / initiative tracking issueEpic / initiative tracking issue
Description
Story
As a PR reviewer (human or agent),
I want see the downstream-impact context inlined in the triage and deeper-review prompts, with guidance to flag potential consumer breakage, and have that signal surfaced in the review output,
so that a reviewer gets a proactive 'this change to X is consumed by N downstream repos' annotation during review, before the change reaches ring-0.
Acceptance Criteria
- The
DOWNSTREAM_IMPACTblock is inlined into the triage prompt assembly inreview-one-pr.sh(alongsideADVISORY_BOT_FEEDBACK), andprompts/triage.mddocuments the new field and how to weigh it. - The deeper tiers (
prompts/single-review.mdand the cascade prompts) receive the block (via the exported file path) andprompts/single-review.mdinstructs the reviewer to call out potential downstream breakage when a shared surface's interface changes. - Prompt guidance makes the signal ADVISORY by default: an interface-breaking change to a consumed surface is called out (and may raise risk), but a mere reference to a touched surface does not by itself force escalation — consistent with the existing triage escalation criteria.
- The review output (verdict/annotation) includes a downstream-impact note when the block is non-empty, naming the impacted surface(s) and the consuming repo(s).
- When the block is
(none)(default / no shared surface touched), prompts and output are unchanged from today — no spurious downstream notes.
Tasks / Subtasks
- Extend the triage prompt builder in
review-one-pr.shto emit aDOWNSTREAM_IMPACTsection (present -> inline the block; absent ->(none)), mirroring theADVISORY_BOT_FEEDBACKconditional. (AC: test issue from agent #1, feat: add Copilot engine support via REVIEW_ENGINE toggle #5) - Document the new field in
prompts/triage.mddecision criteria (weigh interface-breaking downstream impact; do not over-escalate on mere references). (AC: test issue from agent #1, Add @claude delegation, auto-merge, and rebase handling #3) - Teach
prompts/single-review.md(and any cascade prompt that reads the advisory file) to read the downstream-impact file and flag potential breakage; surface it in the verdict. (AC: Go-live improvements for PR review agent #2, Add @claude delegation, auto-merge, and rebase handling #3, Optimize review: small-PR and incremental fast paths #4) - Ensure the verdict/annotation includes a concise downstream-impact note only when the block is non-empty. (AC: Optimize review: small-PR and incremental fast paths #4, feat: add Copilot engine support via REVIEW_ENGINE toggle #5)
Dev Notes
- Triage assembly site: the
{ cat prompts/triage.md; ...; }block inreview-one-pr.sh(around L523-L545). Add theDOWNSTREAM_IMPACTsection using the SAME conditional shape asADVISORY_BOT_FEEDBACK(if non-empty -> inline; else -> (none)). - Triage semantics: see
prompts/triage.mddecision criteria — escalation is for high-risk/unaddressed-findings. Frame downstream impact so an interface-breaking change to a consumed reusable/lib/prompt is a flaggable concern (may justify escalation), but a benign touch of a consumed file is informational. When in doubt the existing 'escalate' default still applies. - Deeper tiers read advisory context via
ADVISORY_BOT_FEEDBACK_FILE; follow the same convention for the downstream-impact file exported by Story 3 sosingle-review.md/ cascade prompts can read it. - This story is prompt + assembly wiring only — the data is already produced by Story 3. Keep behavior byte-for-byte identical when the block is
(none)so existing adopters are unaffected. - Risk taxonomy reference:
prompts/single-review.mdHIGH list already includes 'Org/project standards violations' — downstream interface breakage is a natural sibling; phrase consistently.
Project Structure Notes
Touches scripts/review-one-pr.sh (triage prompt builder) and prompts/triage.md + prompts/single-review.md (and any cascade prompt that consumes the advisory file). No new files.
References
- scripts/review-one-pr.sh#L523-L545
- prompts/triage.md#Decision-criteria
- prompts/single-review.md#Risk-classification
Likely target surface
scripts/review-one-pr.shprompts/triage.mdprompts/single-review.md
Story prepared by the BMAD Scrum Master (Bob) for epic #727. Status: ready-for-dev.
Metadata
Metadata
Assignees
Labels
initiativeEpic / initiative tracking issueEpic / initiative tracking issue
Activity
github-actions commentedon Jun 15, 2026
Superseded by the re-planned initiative epic #748 (re-planned from idea discussion #653).