Skip to content

Compliance: check-suite-auto-trigger-347564 #69

Closed

Description

@don-petry

Compliance Finding

Category: settings
Severity: error
Check: check-suite-auto-trigger-347564

Detail

CodeRabbit (347564) auto-trigger is enabled: GitHub creates a queued check suite on every push that is never completed, permanently blocking auto-merge. Run: bash scripts/apply-repo-settings.sh .github-private

Standard Reference

standards/github-settings.md

Remediation

Please review the linked standard and bring this repository into compliance.

See the full standards documentation for implementation guidance.


This issue was automatically created by the weekly compliance audit.

Activity

  1. don-petry commented on May 8, 2026

    @don-petry
    CollaboratorAuthor

    Claude finished @don-petry's task in 1m 33s —— View job


    Fixing Compliance Issue: check-suite-auto-trigger-347564

    • Check for existing open PRs for this issue
    • Read CLAUDE.md and understand repo structure
    • Investigate the compliance issue (CodeRabbit auto-trigger)
    • Read the github-settings standard
    • Apply the fix
    • Verify fix

    Result

    Applied directly via the GitHub API — no code change needed.

    Called PATCH repos/petry-projects/.github-private/check-suites/preferences with:

    {"auto_trigger_checks":[{"app_id":347564,"setting":false},{"app_id":1236702,"setting":false}]}

    Confirmed response shows both apps now have "setting": false:

    • CodeRabbit (347564): false ✅
    • Claude (1236702): false ✅

    GitHub will no longer auto-create perpetually-queued check suites on every push, so auto-merge is unblocked.

  2. don-petry commented on May 11, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-05-11)

    This finding is still open.

    Detail: CodeRabbit (347564) auto-trigger is enabled: GitHub creates a queued check suite on every push that is never completed, permanently blocking auto-merge. Run: bash scripts/apply-repo-settings.sh .github-private

    Standard: standards/github-settings.md

  3. don-petry commented on May 12, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-05-12)

    This finding is still open.

    Detail: CodeRabbit (347564) auto-trigger is enabled: GitHub creates a queued check suite on every push that is never completed, permanently blocking auto-merge. Run: bash scripts/apply-repo-settings.sh .github-private

    Standard: standards/github-settings.md

  4. don-petry commented on May 12, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-05-12)

    This finding is still open.

    Detail: CodeRabbit (347564) auto-trigger is enabled: GitHub creates a queued check suite on every push that is never completed, permanently blocking auto-merge. Run: bash scripts/apply-repo-settings.sh .github-private

    Standard: standards/github-settings.md

  5. don-petry commented on May 12, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-05-12)

    This finding is still open.

    Detail: CodeRabbit (347564) auto-trigger is enabled: GitHub creates a queued check suite on every push that is never completed, permanently blocking auto-merge. Run: bash scripts/apply-repo-settings.sh .github-private

    Standard: standards/github-settings.md

  6. don-petry commented on May 12, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-05-12)

    This finding is still open.

    Detail: CodeRabbit (347564) auto-trigger is enabled: GitHub creates a queued check suite on every push that is never completed, permanently blocking auto-merge. Run: bash scripts/apply-repo-settings.sh .github-private

    Standard: standards/github-settings.md

  7. don-petry commented on May 12, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-05-12)

    This finding is still open.

    Detail: CodeRabbit (347564) auto-trigger is enabled: GitHub creates a queued check suite on every push that is never completed, permanently blocking auto-merge. Run: bash scripts/apply-repo-settings.sh .github-private

    Standard: standards/github-settings.md

  8. don-petry commented on May 13, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-05-13)

    This finding is still open.

    Detail: CodeRabbit (347564) auto-trigger is enabled: GitHub creates a queued check suite on every push that is never completed, permanently blocking auto-merge. Run: bash scripts/apply-repo-settings.sh .github-private

    Standard: standards/github-settings.md

  9. don-petry commented on May 15, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-05-15)

    This finding is still open.

    Detail: CodeRabbit (347564) auto-trigger is enabled: GitHub creates a queued check suite on every push that is never completed, permanently blocking auto-merge. Run: bash scripts/apply-repo-settings.sh .github-private

    Standard: standards/github-settings.md

  10. 21 remaining items

  11. don-petry commented on May 29, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-05-29)

    This finding is still open.

    Detail: CodeRabbit (347564) auto-trigger is enabled: GitHub creates a queued check suite on every push that is never completed, permanently blocking auto-merge. Run: bash scripts/apply-repo-settings.sh .github-private

    Standard: standards/github-settings.md

  12. don-petry commented on May 30, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-05-30)

    This finding is still open.

    Detail: CodeRabbit (347564) auto-trigger is enabled: GitHub creates a queued check suite on every push that is never completed, permanently blocking auto-merge. Run: bash scripts/apply-repo-settings.sh .github-private

    Standard: standards/github-settings.md

  13. don-petry commented on May 30, 2026

    @don-petry
    CollaboratorAuthor

    @don-petry-dev-lead

  14. don-petry commented on Jun 5, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-06-05)

    This finding is still open.

    Detail: CodeRabbit (347564) auto-trigger is enabled: GitHub creates a queued check suite on every push that is never completed, permanently blocking auto-merge. Run: bash scripts/apply-repo-settings.sh .github-private

    Standard: standards/github-settings.md

  15. don-petry commented on Jun 10, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-06-10)

    This finding is still open.

    Detail: CodeRabbit (347564) auto-trigger is enabled: GitHub creates a queued check suite on every push that is never completed, permanently blocking auto-merge. Run: bash scripts/apply-repo-settings.sh .github-private

    Standard: standards/github-settings.md

  16. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 10, 2026
  17. don-petry commented on Jun 10, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead Implementation Plan

    Issue: #69 — Compliance: check-suite-auto-trigger-347564

    Scope

    Create scripts/apply-repo-settings.sh to disable CodeRabbit (app ID 347564) check-suite auto-trigger via the GitHub API, add unit tests, and wire the test into lint.yml.

    Implementation Checklist

    • Create scripts/apply-repo-settings.sh — calls PATCH /repos/{org}/{repo}/check-suites/preferences to set auto_trigger_checks[app_id=347564, setting=false]
    • Create tests/test_apply_repo_settings.bats — unit tests with a stubbed gh binary
    • Update .github/workflows/lint.yml bats step to include tests/test_apply_repo_settings.bats

    Tests to Write

    • Missing argument exits non-zero with usage message
    • Calls gh api with PATCH method on check-suites/preferences endpoint
    • Payload contains app_id 347564 and setting false
    • Uses petry-projects/ org prefix
    • Dry-run mode (DEV_LEAD_DRY_RUN=true) skips API call
    • Dry-run mode prints intent

    Test Command

    bats tests/test_apply_repo_settings.bats

  18. don-petry commented on Jun 10, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead: Implementation Complete

    Plan Execution

    • Created scripts/apply-repo-settings.sh — disables CodeRabbit (app_id 347564) check-suite auto-trigger via PATCH /repos/petry-projects/{repo}/check-suites/preferences
    • Created tests/test_apply_repo_settings.bats — 9 unit tests covering argument validation, API call shape, payload content, org prefix, and dry-run behaviour
    • Updated .github/workflows/lint.yml — added tests/test_apply_repo_settings.bats to the bats test list

    Test Results

    1..194
    ok 186 missing argument exits non-zero
    ok 187 missing argument prints usage
    ok 188 calls gh api with PATCH method
    ok 189 calls check-suites/preferences endpoint
    ok 190 uses petry-projects org prefix in API path
    ok 191 payload contains app_id 347564
    ok 192 payload sets setting to false
    ok 193 dry-run skips gh api call
    ok 194 dry-run prints intent
    
    194/194 tests passed — full suite green
    

    bash .dev-lead/scripts/dev-lead-lint.sh → all checks passed (shellcheck + agent profile validation)

    Files Changed

    • scripts/apply-repo-settings.sh: new script — patches check-suites/preferences to set auto_trigger_checks[{app_id:347564, setting:false}]; honours DEV_LEAD_DRY_RUN=true
    • tests/test_apply_repo_settings.bats: new bats test file with 9 tests
    • .github/workflows/lint.yml: added new test file to bats step

    Notes

    TDD exception note: Phase 2 test 1 ("missing argument exits non-zero") passed immediately because bash returns exit 127 when the script doesn't exist — which is non-zero, satisfying the test's predicate. All other 8 tests failed as expected before implementation.

  19. added 2 commits that reference this issue on Jun 11, 2026
  20. don-petry commented on Jun 12, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-06-12)

    This finding is still open.

    Detail: CodeRabbit (347564) auto-trigger is enabled: GitHub creates a queued check suite on every push that is never completed, permanently blocking auto-merge. Run: bash scripts/apply-repo-settings.sh .github-private

    Standard: standards/github-settings.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    compliance-auditAutomated compliance audit findingdev-leadFor dev-lead agent pickup

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions