Repository navigation
Closed
Labels
bugBug reportsBug reports
Description
Parent: #495 · Work type: Infra · Surfaced repeatedly while landing #440 / #448 / #571.
Problem
Merging agent/maintainer-authored infrastructure PRs is consistently high-friction. Recurring blockers, none code-quality related:
- Self-author can't approve. PRs are opened as
don-petry(the gh-authed identity). The org-leads CODEOWNER approval must come from a different identity —donpetry-bot(the pr-review agent). GitHub blocks self-approval. require_last_push_approvalvs the bot pusher. Whendonpetry-botpushes the last commit (e.g. the dev-lead agent auto-addressing review feedback), its own approval no longer satisfiesrequire_last_push_approval— needing a trivialdon-petrypush to reset the last-pusher.- CodeRabbit
CHANGES_REQUESTEDstickiness. A laterCOMMENTEDreview does not clear a priorCHANGES_REQUESTED; it persists on a stale commit and blocksreviewDecisioneven with 0 unresolved threads, until CodeRabbit re-APPROVEs or the review is dismissed. - Flaky
.githubreview automation. On the public.githubrepo,pr-review-mentionskips/fails (e.g. 'Post acknowledgement comment' exit 1) andpr-auto-reviewdoesn't reliably dispatch the agent — so the org-leads approval never lands on its own. - CI-gate interaction (tracked in pr-review CI gate should gate on REQUIRED checks only — non-required CANCELLED *and* FAILED checks falsely block reviews #608): non-required failed/cancelled checks make the agent skip approving.
Evidence
- petry-projects — workflow failures detected 2026-06-06 #440 — needed: empty commit to reset last-pusher +
@donpetry-bot+@coderabbitai reviewto clear a stale CR review. - dev-lead: in-place
gh pr checkoutclobbers the agent's own prompt/script files on older PR branches #448 — agent approval never landed on.github; left to wait. - fix(engine): reorder cross-provider fallback to claude → copilot → gemini #571 — stale CR
CHANGES_REQUESTEDdismissed manually + admin-merge (the CI-gate deadlock, pr-review CI gate should gate on REQUIRED checks only — non-required CANCELLED *and* FAILED checks falsely block reviews #608).
Possible directions (for discussion)
- A dedicated reviewer identity / GitHub App that supplies the org-leads CODEOWNER approval reliably (decoupled from the author + last-pusher).
- Auto-dismiss stale bot
CHANGES_REQUESTEDreviews on push (a small action), or treat bot reviews as advisory (not gating). - Relax
require_last_push_approvalfor bot-authored fix commits on agent-infra PRs, or have the agent always make the human the last pusher. - Fix the
.githubpr-review-mention/pr-auto-reviewdispatch reliability.
This is the systemic root behind much of the manual PR-unsticking. Pairs with #608 (CI gate) — together they'd remove most agent-PR merge friction.
Metadata
Metadata
Assignees
Labels
bugBug reportsBug reports
Activity
don-petry commentedon Jul 14, 2026
Mitigation status (2026-07-14)
Blocker #5 (CI-gate interaction) is now fully addressed: #608 made superseded CANCELLED dev-lead checks non-blocking, and PR #1230 (#619) lets a manual
FORCE_REVIEWbypass theci-failinggate — so an agent PR carrying a failing non-required check can now be approved via @mention (the ruleset still blocks genuinely-failing required checks). The auto-rebaseauto-rebase:readylabeling (#1201/#1202) + Part C (#713) and the stuck-review sweep (#573/#898) also reduce the friction in blockers #1/#4.Remaining are process/posture decisions (your call — I've deliberately not changed these unilaterally):
require_last_push_approval— relax for bot-authored fix commits, or always make the human the last pusher. (Addresses Go-live improvements for PR review agent #2 — branch-protection change.).githubdispatch reliability — fixpr-review-mention/pr-auto-reviewflakiness on the public repo. (Addresses Optimize review: small-PR and incremental fast paths #4 — a separate reliability fix.)Each is a security/process-posture choice; happy to implement whichever direction you pick.
feat(pr): auto-dismiss stale bot CHANGES_REQUESTED on push (#617) (#1233
don-petry commentedon Oct 21, 2026
Closing after the 2026-10-21 backlog triage.
Why: Grab-bag of June friction; mitigations shipped; remaining bot friction is #2276 B.
Evidence: PRs #1230, #1233; #1316 fix; #2276 B
Reopen if this still reproduces on main.