Repository navigation
Closed as not planned
Closed as not planned
Copy link
Labels
dev-leadFor dev-lead agent pickupFor dev-lead agent pickupinitiativeEpic / initiative tracking issueEpic / initiative tracking issue
Description
Story
As a org-lead responsible for the production reviewer,
I want the generalized review agent promoted through the Safe Release rings/channels rather than shipped straight to stable,
so that the behavior-preserving refactor reaches stable only after ring-staged validation.
Acceptance Criteria
- The refactored review agent is cut as a versioned release and promoted via the ring/channel pipeline (ring 0 self-host -> 1 low-traffic -> 2 rest), not pushed straight to the stable channel.
- The pr-review/stable channel tag is moved only after ring validation, per the Safe Release Strategy.
- The new artifact-type registrations (plan_json, skill_candidate) ride the same channel promotion.
Tasks / Subtasks
- Cut a versioned release of the refactored agent and start at ring 0 (self-host) using the existing release tooling (scripts/cut-release.sh / channel tags). (AC: test issue from agent #1)
- Validate at each ring, then move the pr-review/stable channel tag. (AC: test issue from agent #1, Go-live improvements for PR review agent #2)
- Confirm consumer trigger stubs (pr-review-trigger.yml @ pr-review/stable) pick up the promoted version. (AC: Go-live improvements for PR review agent #2, Add @claude delegation, auto-merge, and rebase handling #3)
Dev Notes
- Safe Release Strategy is Epic Initiative: Safe Release Strategy for Agentic Workflows (versioning · rings · canary) #495; relevant pieces are [Phase 1] Pin all callers off @main to the stable tag (consumer repos + self-review/dev duty) #497 (pin callers off @main to stable), [Phase 2] Add next + per-ring channel tags (blue/green green channel) #499 (next + per-ring channel tags), [Phase 2] Define concentric rings (0 self-host → 1 low-traffic → 2 rest) + keep production duty on stable #500 (concentric rings 0->1->2), [Phase 2] Replace PUT-contents clobber deploy with versioned, ring-staged, health-gated promotion #501 (versioned ring-staged health-gated promotion). Use that pipeline; do not invent a new release path.
- pr-review-trigger.yml is a thin caller pinned to pr-review/stable; promotion reaches consumers via the channel-tag mechanism (scripts/cut-release.sh; AGENTS.md documents the first-party mutable-channel exception to the SHA-pin rule).
- hands_off: ring promotion to stable is a human release decision and must never be auto-released to dev-lead.
- Sequenced after the pr_diff regression guard (Story 3) so only proven behavior-preserving code is promoted; new-type registrations follow the same channel.
Project Structure Notes
No new source; this is a release/operations story touching release channel tags and verifying pr-review-trigger.yml. cut-release.sh is exercised by tests/test_cut_release.bats.
References
- .github/workflows/pr-review-trigger.yml
- .github/workflows/pr-review.yml
- scripts/cut-release.sh
- AGENTS.md#workflow-files
- tests/test_cut_release.bats
Likely target surface
.github/workflows/pr-review-trigger.ymlscripts/cut-release.sh
Story prepared by the BMAD Scrum Master (Bob) for epic #610. Status: ready-for-dev.
Metadata
Metadata
Assignees
Labels
dev-leadFor dev-lead agent pickupFor dev-lead agent pickupinitiativeEpic / initiative tracking issueEpic / initiative tracking issue
Activity
don-petry commentedon Jul 10, 2026
Dev-Lead: Ring-Staged Promotion Hand-Off (Issue #616)
This is a release/operations story whose acceptance criteria are human-gated and cannot be executed by the dev-lead agent. Reporting a verified hand-off rather than a code change, per the issue's own
hands_offnote.Why no code change / no autonomous promotion
hands_off(issue Dev Notes): "ring promotion to stable is a human release decision and must never be auto-released to dev-lead."release-channel-tagsruleset (AGENTS.md→ "Release channel tags & the mutable-ref exception";docs/release/runbook.md§Roles) restrictspr-review/**tagupdate/deletionto OrganizationAdmin + the automation Integration app. The dev-lead agent runs asGITHUB_TOKENand cannot cut or move any release/channel tag.main(faf7ec2);plan_jsonandskill_candidateare already registered inscripts/lib/review-registry.tsv; andscripts/cut-release.shalready accepts arbitrary--channelnames, so it already supports ring-stagedpr-reviewpromotion. Nothing to implement.Pipeline verified (dry-run, no tags touched)
The tooling resolves and targets the correct host repo (
petry-projects/.github-private) at the refactored HEAD.Two premise corrections for the release manager
pr-review-trigger.ymlis pinned topr-review/next(this repo is the ring-0 self-host canary), notpr-review/stableas the Dev Notes state. Thestable-pinned consumers are the fleet trigger stubs in other repos.docs/release/versioning.mdandrunbook.md§2c,pr-reviewcurrently has onlynext+stable— itsring0/ring1channels are pending under [Phase 2] Add next + per-ring channel tags (blue/green green channel) #499. A literalring 0 → 1 → 2staging forpr-reviewneeds [Phase 2] Add next + per-ring channel tags (blue/green green channel) #499 to land the intermediate ring channels first; today's available staging isnext(self-host) →stable(fleet).Human release-manager checklist (AC #1, #2, #3)
Run once #499's ring channels exist for the full 0→1→2 path; the
next → stablepath is available today.plan_json+skill_candidateride along automatically (same repo commit the tag points at).Status
cut-release.shring-staged pipeline (dry-run) for the refactoredpr-reviewagentplan_json/skill_candidateride the same channel promotion (registry rows on the tagged commit)pr-review/next)pr-review/vX.Y.Z, stage through rings, movepr-review/stableafter ring validation (hands_off)No source files changed — this story's actionable work is a human-gated release operation.
don-petry commentedon Jul 14, 2026
Human sign-off: APPROVED to promote the generalized review agent to stable (maintainer, 2026-07-13)
The org-lead signs off on promoting the behavior-preserving review-agent refactor through the Safe Release rings to the
pr-review/stablechannel (AC#1/AC#2), with the new artifact-type registrations (plan_json,skill_candidate) riding the same channel (AC#3).Operational step: the
pr-review/stablechannel-tag move is a release action viascripts/cut-release.sh/ the canary-rollout promotion. Sign-off recorded here authorizes it; flagging the tag move as the remaining step before #610 closes. — Claude Codedon-petry commentedon Oct 21, 2026
Closing after the 2026-10-21 backlog triage.
Why: Refactor (PR #622, 2026-06-14) long since in pr-review/stable (e524d16, 2026-10-14).
Evidence: tag pr-review/stable=e524d16d
Reopen if this still reproduces on main.