Skip to content

Compliance: non-stub-dependency-audit.yml #545

Closed

Description

@don-petry

Compliance Finding

Category: ci-workflows
Severity: error
Check: non-stub-dependency-audit.yml

Detail

Centralized workflow dependency-audit.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/dependency-audit.yml which delegates to petry-projects/.github/.github/workflows/dependency-audit-reusable.yml@v1.

Standard Reference

standards/ci-standards.md#centralization-tiers

Remediation

Please review the linked standard and bring this repository into compliance.

See the full standards documentation for implementation guidance.


This issue was automatically created by the weekly compliance audit.

Activity

  1. don-petry commented on Jun 10, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead Implementation Plan

    Issue: #545 — Compliance: non-stub-dependency-audit.yml

    Scope

    Replace @v2 with @v1 in .github/workflows/dependency-audit.yml to match the canonical stub at petry-projects/.github/standards/workflows/dependency-audit.yml.

    Implementation Checklist

    • Write failing test (tests/dev-lead/integration/test_dependency_audit_stub.py) that asserts dependency-audit.yml delegates to the reusable at @v1
    • Fix .github/workflows/dependency-audit.yml: change uses: …@v2 → uses: …@v1

    Tests to Write

    • tests/dev-lead/integration/test_dependency_audit_stub.py — validates the uses: line in dependency-audit.yml is pinned to @v1 (mirrors test_workflow_toplevel_permissions.py pattern)

    Test Command

    python3 tests/dev-lead/integration/test_dependency_audit_stub.py

  2. don-petry commented on Jun 10, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead: Implementation Complete

    Plan Execution

    • Write failing test (tests/dev-lead/integration/test_dependency_audit_stub.py) asserting @v1 pin — confirmed red before fix
    • Fix .github/workflows/dependency-audit.yml: changed uses: …@v2 → uses: …@v1 to match canonical stub
    • Test passes green, full test suite passes, dev-lead-lint passes

    Test Results

    python3 tests/dev-lead/integration/test_dependency_audit_stub.py
    PASS: .github/workflows/dependency-audit.yml job 'dependency-audit' delegates to petry-projects/.github/.github/workflows/dependency-audit-reusable.yml@v1
    
    bash .dev-lead/scripts/dev-lead-lint.sh
      [lint] shellcheck on 40 file(s)...
      [lint] validating 4 agent profile(s)...
    OK: agents/agentic-workflows.md
    OK: agents/compliance-auditor.md
    OK: agents/feature-ideator.md
    OK: agents/pr-reviewer.md
      [lint] all checks passed
    
    tests/test_copilot_chat.sh: 13 passed, 0 failed
    tests/test_list_prs_sort.sh: 17 passed, 0 failed
    

    Files Changed

    • .github/workflows/dependency-audit.yml: changed uses: pin from @v2 to @v1 to match the canonical org stub at petry-projects/.github/standards/workflows/dependency-audit.yml
    • tests/dev-lead/integration/test_dependency_audit_stub.py: new test that validates the uses: line is pinned to @v1

    Notes

    The only difference between the canonical stub and this repo's file was the reusable ref (@v2 vs the required @v1). All other header comments, triggers, permissions, and job names were already correct and unchanged.

  3. added a commit that references this issue on Jun 10, 2026
  4. added 12 commits that reference this issue on Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    compliance-auditAutomated compliance audit findingdev-leadFor dev-lead agent pickup

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions