You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Centralized workflow dev-lead.yml is an inline copy instead of a thin caller stub — re-sync from standards/workflows/dev-lead.yml. Replace with the canonical stub from standards/workflows/dev-lead.yml which delegates to petry-projects/.github/.github/workflows/dev-lead-reusable.yml@v1.
Detail: Centralized workflow dev-lead.yml is an inline copy instead of a thin caller stub — re-sync from standards/workflows/dev-lead.yml. Replace with the canonical stub from standards/workflows/dev-lead.yml which delegates to petry-projects/.github/.github/workflows/dev-lead-reusable.yml@v1.
Detail: Centralized workflow dev-lead.yml is an inline copy instead of a thin caller stub — re-sync from standards/workflows/dev-lead.yml. Replace with the canonical stub from standards/workflows/dev-lead.yml which delegates to petry-projects/.github/.github/workflows/dev-lead-reusable.yml@v1.
Detail: Centralized workflow dev-lead.yml is an inline copy instead of a thin caller stub — re-sync from standards/workflows/dev-lead.yml. Replace with the canonical stub from standards/workflows/dev-lead.yml which delegates to petry-projects/.github/.github/workflows/dev-lead-reusable.yml@v1.
Replace the inline .github/workflows/dev-lead.yml with the canonical thin caller stub from standards/workflows/dev-lead.yml (which delegates all logic to petry-projects/.github-private/.github/workflows/dev-lead-reusable.yml@main), and update associated tests and docs.
Implementation Checklist
Write failing test: tests/dev-lead/integration/test_dev_lead_stub.sh — verifies dev-lead.yml is a thin caller stub (currently fails because the file is inline)
Replace .github/workflows/dev-lead.yml with canonical stub from standards/workflows/dev-lead.yml (verbatim)
Update tests/dev-lead/integration/test_concurrency_config.sh — remove dev-lead.yml from the checked-workflows list (per-PR/per-issue routing is now centralized in the reusable; the stub only needs the ci-relay group)
Update AGENTS.md — replace the "runs inline steps directly" note with accurate thin-caller description
Tests to Write
tests/dev-lead/integration/test_dev_lead_stub.sh: assert dev-lead.yml contains uses: petry-projects/.github-private/.github/workflows/dev-lead-reusable.yml@main and does NOT contain inline job steps (red before implementation, green after)
This is a YAML workflow configuration change, not a code behaviour change. The new failing test verifies the structural contract (stub delegates to reusable). Existing concurrency tests for dev-lead-reusable.yml continue to validate the per-PR/per-issue routing that the stub inherits via delegation.
Wrote failing test tests/dev-lead/integration/test_dev_lead_stub.sh (TDD red: 3 checks failed against old inline workflow)
Replaced .github/workflows/dev-lead.yml with canonical thin caller stub (verbatim from standards/workflows/dev-lead.yml)
Updated tests/dev-lead/integration/test_concurrency_config.sh — removed dev-lead.yml from checked workflows (per-PR/per-issue routing is now centralised in the reusable; stub validated separately)
Updated AGENTS.md — replaced stale "runs inline steps directly" note with accurate thin-caller description
Test Results
# test_dev_lead_stub.sh (new test)
PASS: dev-lead.yml delegates to dev-lead-reusable.yml@main
PASS: dev-lead.yml contains no inline run: steps (thin caller confirmed)
PASS: dev-lead.yml has workflow-level permissions: {}
All stub-structure checks passed.
# test_concurrency_config.sh
PASS [per-PR serialization lane]: 'dev-lead-pr-' present in concurrency YAML of dev-lead-reusable.yml
PASS [per-issue serialization lane]: 'dev-lead-issue-' present in concurrency YAML of dev-lead-reusable.yml
PASS [ci-relay per-SHA group]: 'dev-lead-ci-relay-' present in concurrency YAML of dev-lead-reusable.yml
PASS [cancel-in-progress is false]: 'cancel-in-progress: false' present in concurrency YAML of dev-lead-reusable.yml
PASS [issue.pull_request before issue lane]: ordering correct
PASS [client_payload.pr_number before run-id fallback]: ordering correct
All concurrency config checks passed.
# test_caller_permissions.py
PASS: caller template grants >= every permission the reusable jobs request.
# scripts/dev-lead-lint.sh
[lint] shellcheck on 34 file(s)...
[lint] validating 4 agent profile(s)...
[lint] all checks passed
Files Changed
.github/workflows/dev-lead.yml: replaced 353-line inline workflow with 60-line canonical thin caller stub (verbatim from standards/workflows/dev-lead.yml)
AGENTS.md: updated workflow description from "runs inline steps directly" to accurate thin-caller description
tests/dev-lead/integration/test_concurrency_config.sh: removed dev-lead.yml from WORKFLOWS array (per-PR routing now centralised in reusable; stub validated by new test)
tests/dev-lead/integration/test_dev_lead_stub.sh(new): validates dev-lead.yml is a thin caller stub (calls reusable, no inline steps, permissions: {})
Notes
The dev-lead-reviews-retry repository_dispatch type was present in the old inline workflow but is absent from the canonical stub. This matches the standard intentionally; reviews retry behaviour goes through the reusable's intent routing. Unit tests for the reviews-retry intent (test_intent_ci.bats) remain intact and unaffected — they test the dev-lead-intent.sh script directly, not the workflow trigger.
The old inline workflow carried per-PR/per-issue concurrency routing; the canonical stub uses a simpler 'dev-lead' group at the caller level. The reusable retains the full per-PR/per-issue routing which applies at the reusable level.
Activity
don-petry commentedon May 29, 2026
Weekly Compliance Audit (2026-05-29)
This finding is still open.
Detail: Centralized workflow
dev-lead.ymlis an inline copy instead of a thin caller stub — re-sync fromstandards/workflows/dev-lead.yml. Replace with the canonical stub fromstandards/workflows/dev-lead.ymlwhich delegates topetry-projects/.github/.github/workflows/dev-lead-reusable.yml@v1.Standard: standards/ci-standards.md#centralization-tiers
don-petry commentedon May 30, 2026
Weekly Compliance Audit (2026-05-30)
This finding is still open.
Detail: Centralized workflow
dev-lead.ymlis an inline copy instead of a thin caller stub — re-sync fromstandards/workflows/dev-lead.yml. Replace with the canonical stub fromstandards/workflows/dev-lead.ymlwhich delegates topetry-projects/.github/.github/workflows/dev-lead-reusable.yml@v1.Standard: standards/ci-standards.md#centralization-tiers
don-petry commentedon May 30, 2026
@don-petry-dev-lead
don-petry commentedon Jun 5, 2026
Weekly Compliance Audit (2026-06-05)
This finding is still open.
Detail: Centralized workflow
dev-lead.ymlis an inline copy instead of a thin caller stub — re-sync fromstandards/workflows/dev-lead.yml. Replace with the canonical stub fromstandards/workflows/dev-lead.ymlwhich delegates topetry-projects/.github/.github/workflows/dev-lead-reusable.yml@v1.Standard: standards/ci-standards.md#centralization-tiers
don-petry commentedon Jun 8, 2026
Dev-Lead Implementation Plan
Issue: #395 — Compliance: non-stub-dev-lead.yml
Scope
Replace the inline
.github/workflows/dev-lead.ymlwith the canonical thin caller stub fromstandards/workflows/dev-lead.yml(which delegates all logic topetry-projects/.github-private/.github/workflows/dev-lead-reusable.yml@main), and update associated tests and docs.Implementation Checklist
tests/dev-lead/integration/test_dev_lead_stub.sh— verifiesdev-lead.ymlis a thin caller stub (currently fails because the file is inline).github/workflows/dev-lead.ymlwith canonical stub fromstandards/workflows/dev-lead.yml(verbatim)tests/dev-lead/integration/test_concurrency_config.sh— removedev-lead.ymlfrom the checked-workflows list (per-PR/per-issue routing is now centralized in the reusable; the stub only needs the ci-relay group)AGENTS.md— replace the "runs inline steps directly" note with accurate thin-caller descriptionTests to Write
tests/dev-lead/integration/test_dev_lead_stub.sh: assertdev-lead.ymlcontainsuses: petry-projects/.github-private/.github/workflows/dev-lead-reusable.yml@mainand does NOT contain inline job steps (red before implementation, green after)Test Command
bash tests/dev-lead/integration/test_concurrency_config.sh && bash tests/dev-lead/integration/test_dev_lead_stub.sh && bash scripts/dev-lead-lint.shTDD Exception Note
This is a YAML workflow configuration change, not a code behaviour change. The new failing test verifies the structural contract (stub delegates to reusable). Existing concurrency tests for
dev-lead-reusable.ymlcontinue to validate the per-PR/per-issue routing that the stub inherits via delegation.don-petry commentedon Jun 8, 2026
Dev-Lead: Implementation Complete
Plan Execution
tests/dev-lead/integration/test_dev_lead_stub.sh(TDD red: 3 checks failed against old inline workflow).github/workflows/dev-lead.ymlwith canonical thin caller stub (verbatim fromstandards/workflows/dev-lead.yml)tests/dev-lead/integration/test_concurrency_config.sh— removeddev-lead.ymlfrom checked workflows (per-PR/per-issue routing is now centralised in the reusable; stub validated separately)AGENTS.md— replaced stale "runs inline steps directly" note with accurate thin-caller descriptionTest Results
Files Changed
.github/workflows/dev-lead.yml: replaced 353-line inline workflow with 60-line canonical thin caller stub (verbatim fromstandards/workflows/dev-lead.yml)AGENTS.md: updated workflow description from "runs inline steps directly" to accurate thin-caller descriptiontests/dev-lead/integration/test_concurrency_config.sh: removeddev-lead.ymlfrom WORKFLOWS array (per-PR routing now centralised in reusable; stub validated by new test)tests/dev-lead/integration/test_dev_lead_stub.sh(new): validatesdev-lead.ymlis a thin caller stub (calls reusable, no inline steps,permissions: {})Notes
dev-lead-reviews-retryrepository_dispatch type was present in the old inline workflow but is absent from the canonical stub. This matches the standard intentionally; reviews retry behaviour goes through the reusable's intent routing. Unit tests for the reviews-retry intent (test_intent_ci.bats) remain intact and unaffected — they test thedev-lead-intent.shscript directly, not the workflow trigger.'dev-lead'group at the caller level. The reusable retains the full per-PR/per-issue routing which applies at the reusable level.feat: implement issue #395 — Compliance: non-stub-dev-lead.yml
feat: implement issue #395 — Compliance: non-stub-dev-lead.yml (#488)
21 remaining items
feat: implement issue #395 — Compliance: non-stub-dev-lead.yml (#488)
feat: implement issue #395 — Compliance: non-stub-dev-lead.yml (#488)
feat: implement issue #395 — Compliance: non-stub-dev-lead.yml (#488)
feat: implement issue #395 — Compliance: non-stub-dev-lead.yml (#488)
feat: implement issue #395 — Compliance: non-stub-dev-lead.yml (#488)
feat: implement issue #395 — Compliance: non-stub-dev-lead.yml (#488)
feat: implement issue #395 — Compliance: non-stub-dev-lead.yml (#488)
feat: implement issue #395 — Compliance: non-stub-dev-lead.yml (#488)
feat: implement issue #395 — Compliance: non-stub-dev-lead.yml (#488)
feat: implement issue #395 — Compliance: non-stub-dev-lead.yml (#488)
feat: implement issue #395 — Compliance: non-stub-dev-lead.yml (#488)
feat: implement issue #395 — Compliance: non-stub-dev-lead.yml (#488)
feat: implement issue #395 — Compliance: non-stub-dev-lead.yml (#488)
feat: implement issue #395 — Compliance: non-stub-dev-lead.yml (#488)
feat: implement issue #395 — Compliance: non-stub-dev-lead.yml (#488)