Skip to content

[Fleet Monitor] petry-projects/.github-private β€” ci.ymlΒ #244

Closed

Description

@donpetry-bot

🟠 DEGRADED: petry-projects/.github-private / ci.yml

Metric Value
Failure Rate 21.4% (9 / 42 runs)
Status DEGRADED
p50 Duration 17s
p95 Duration 26s
Successful Runs 33
Cancelled Runs 0

Workflow: ci.yml

Last updated by Fleet Monitor run on 2026-06-05.
Threshold: failure rate > 10% over the monitored window.

Activity

  1. added
    dev-leadFor dev-lead agent pickup
    fleet-trackerTracked by the Actions Fleet Monitor
    health-checkAutomated health check report
    on May 18, 2026
  2. don-petry commented on May 21, 2026

    @don-petry
    Collaborator

    dev-lead - Investigate and fix

  3. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 9, 2026
  4. don-petry commented on Jun 9, 2026

    @don-petry
    Collaborator
    All engines are currently rate-limited. Please re-apply the `dev-lead` label when the rate limit clears to retry.
  5. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 9, 2026
  6. don-petry commented on Jun 9, 2026

    @don-petry
    Collaborator

    Dev-Lead Implementation Plan

    Issue: #244 β€” [Fleet Monitor] petry-projects/.github-private β€” ci.yml

    Root Cause Analysis

    Two failure patterns drove the 21.4% failure rate:

    1. Actionlint download instability (primary β€” ~7 failures): The old ci.yml downloaded actionlint via curl, which hit transient GitHub CDN 504 errors (exit code 22). This was already fixed in the current ci.yml by switching to gh release download with the comment "Uses gh release download rather than direct CDN curl to avoid transient 504s from GitHub's release asset CDN."

    2. Gitleaks false positives (ongoing β€” ~5 failures): The secret-scan job with fetch-depth: 0 causes gitleaks to scan all git history in PR context (600-1000+ commits). Branches that included commits from the old frameworks/ git subtree (since removed via chore: remove frameworks directory (#101)) triggered the generic-api-key rule on test fixture files:

      • frameworks/bmad-method/test/adversarial-review-tests/sample-content.md (line 24) β€” sample content with "token": "value"
      • frameworks/gsd/sdk/src/query/config-query.test.ts (line 228) β€” const apiKey = '...'
      • frameworks/gsd/sdk/src/query/config-mutation.test.ts (line 501) β€” const apiKey = '...'
      • frameworks/gsd/tests/commands.test.cjs (line 759) β€” test fixture

    Scope

    Add .gitleaks.toml to suppress false positives from the frameworks/ git-subtree directory (removed from tree but present in history), and add a BATS test to validate the config structure.

    Implementation Checklist

    • Create .gitleaks.toml with path-based allowlist for frameworks/
    • Create tests/test_gitleaks_config.bats to validate config presence and structure
    • Add tests/test_gitleaks_config.bats to .github/workflows/lint.yml BATS test list

    Tests to Write

    • tests/test_gitleaks_config.bats: assert .gitleaks.toml exists, parses as valid TOML, and includes frameworks/ in the allowlist paths

    Test Command

    bash scripts/dev-lead-lint.sh

  7. don-petry commented on Jun 9, 2026

    @don-petry
    Collaborator

    Dev-Lead: Implementation Complete

    Root Cause Summary

    Two failure patterns drove the 21.4% failure rate:

    1. Actionlint download instability (~7 failures, already fixed): The old ci.yml downloaded actionlint via curl, hitting transient GitHub CDN 504 errors (exit code 22). The current ci.yml already contains the fix β€” gh release download with the explicit comment "Uses gh release download rather than direct CDN curl to avoid transient 504s from GitHub's release asset CDN."

    2. Gitleaks false positives (~5 failures, fixed by this PR): The secret-scan job scans PR history (600–1000+ commits) and finds fake API keys in test fixture files from the old frameworks/ git subtree (removed in commit d42bfe7). Affected files: frameworks/bmad-method/test/adversarial-review-tests/sample-content.md, frameworks/gsd/sdk/src/query/config-query.test.ts, frameworks/gsd/sdk/src/query/config-mutation.test.ts, frameworks/gsd/tests/commands.test.cjs.

    Plan Execution

    • Analyzed 200 historical CI runs to identify failure patterns
    • Confirmed false positives are in frameworks/ test fixtures (not real credentials)
    • Wrote failing BATS test (tests/test_gitleaks_config.bats) β€” red phase confirmed
    • Created .gitleaks.toml with frameworks/ path allowlist β€” green phase confirmed
    • Added tests/test_gitleaks_config.bats to lint.yml BATS test list
    • bash scripts/dev-lead-lint.sh β€” all checks passed
    • yamllint on all workflow files β€” passed

    Test Results

    [lint] shellcheck on 40 file(s)...
    [lint] validating 4 agent profile(s)...
    OK: agents/agentic-workflows.md
    OK: agents/compliance-auditor.md
    OK: agents/feature-ideator.md
    OK: agents/pr-reviewer.md
    [lint] all checks passed
    
    yamllint: exit 0 (no errors)
    
    Python test validation:
    Test 1: .gitleaks.toml exists at repo root β€” PASS
    Test 2: .gitleaks.toml is valid TOML β€” PASS
    Test 3: .gitleaks.toml allowlist covers frameworks/ path β€” PASS
    

    Files Changed

    • .gitleaks.toml (new): Extends default gitleaks config with a global path allowlist for frameworks/ β€” suppresses false positives from git-subtree test fixtures in historical commits
    • tests/test_gitleaks_config.bats (new): BATS tests validating config presence, TOML validity, and allowlist coverage
    • .github/workflows/lint.yml: Added tests/test_gitleaks_config.bats to the BATS test list

    Notes

    The [extend] useDefault = true directive preserves the full default gitleaks ruleset β€” only the frameworks/ path is exempted, not any rule globally. Push events to main are unaffected (gitleaks only scans the latest commit on push). The allowlist protects PR branches that include the historical frameworks/ subtree commits from surfacing false positives going forward.

  8. 34 remaining items

  9. added 14 commits that reference this issue on Aug 7, 2026
  10. added a commit that references this issue on Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dev-leadFor dev-lead agent pickupfleet-trackerTracked by the Actions Fleet Monitorhealth-checkAutomated health check report

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions