Skip to content

solution-architect PR advisories are invisible to dev-lead and the approval gate (same persona-marker exemption as qa-lead) #2203

Open

Description

@don-petry

Problem

The Solution Architect persona's PR advisory has the same fate as qa-lead's: dev-lead never responds and the approval gate never requires a response.

Unlabelled on purpose. This needs the same policy ruling as the qa-lead companion issue.

Mechanism

  • Reach. It is served only via @mention (personas/solution-architect/persona.yml:63-75, interaction.yml:8-12).
  • How it posts. It posts as don-petry through the same persona runner (persona.yml:100-103), so the body carries <!-- persona:solution-architect -->.
  • Same three skips as qa-lead:
    • gate exemption, maintainer-comment-gate.sh:74;
    • prompt skip, fix-reviews.md:161;
    • no dev-lead intent, dev-lead-intent.sh:635-640.
  • Escalation. prompts/solution-architect/advisory.md:111: "you cannot block, only say so". Nothing reads its escalation.
  • Contract. Its contract emits only comment:advisory-response. Nothing obliges dev-lead to answer.

Impact is lower than qa-lead's because a human must summon it. That also means the human asked for the input and expects it acted on, which makes silently ignoring it worse.

Proposed acceptance criteria (pending the policy ruling)

  1. Apply the same fix as qa-lead: split the recursion guard from the disposition exemption, and have dev-lead disposition each finding.
  2. Architecture escalations hold the PR until a maintainer or a fixed disposition clears them.
  3. Record the obligation in interaction-contracts/dev-lead.yml.
  4. Prefer one shared mechanism for all advisory personas (qa-lead, solution-architect, security-lead, sre-lead, devops-lead) rather than per-persona special cases.

Related

Filed from a Claude Code session auditing dev-lead gaps, 2026-10-10.

Activity

  1. don-petry commented on Oct 10, 2026

    @don-petry
    CollaboratorAuthor

    Companion issue for qa-lead: #2202. One shared fix for both is preferred.


    Generated by Claude Code

  2. github-actions commented on Oct 10, 2026

    @github-actions
    Contributor

    Thanks for the detailed write-up and for tracing the exact skip points (gate exemption, prompt skip, and missing dev-lead intent). To confirm the scope before work starts: for architecture escalations from solution-architect, should an unresolved one hold the PR until a maintainer or a fixed disposition clears it, or should it only require that dev-lead record a disposition without blocking merge? Given #1787 (over-escalation), the answer determines whether calibration has to land before enforcement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions