Skip to content

Sync the markets collapse package §3/§4b to the deployed ingress (pr-auto-review group + ci-failure-analyst pin) #2171

Closed

Description

@don-petry

Problem

The markets collapse PR (combsmith/markets#513) deploys an agent-ingress.yml that differs from the ratified package §3 (merged in #2039) in TWO places. The package is the source of truth and the pilot's evidence trail, so it must be updated to match what actually ships. The maintainer accepted both deviations.

What changed in the deployed file

  1. ci-failure-analyst pin: @79747178007d3238bb3afddf7f4d952a293987bd → @b58510275dd1cbbd13c0733c15265d51fd63b992 (carries markets main's Dependabot bump e390f85 rather than silently reverting it). The reusable at the new pin declares no concurrency, so the ADR-0010 collision outcome is unchanged.
  2. pr-auto-review job concurrency.group: replace the per-head-SHA slot with a per-event slot. Deployed block (verbatim):
    concurrency:
      group: >-
        pr-auto-review-${{
        github.event.pull_request.number
        || github.event.check_suite.id
        || github.event.workflow_run.id
        || 'none'
        }}
      cancel-in-progress: true

Why: it satisfies ADR-0010 (literal role prefix, event-payload reads only, no run_id, literal cancel-in-progress) and is closer to the deleted stub: non-PR events get their own slot (as the stub's unique per-run slot did) instead of coalescing per commit, which avoids the cross-PR cancellation hazard the stub documented in #1126.

Required changes (docs/initiatives/agent-ingress-collapse-markets.md, plus the bats that extracts it)

  1. §3 YAML: update the pr-auto-review group to the block above and the ci-failure-analyst uses: SHA to b5851027…. Keep every other line byte-identical to the deployed markets file.
  2. §4a conformance table and §4b: rewrite the pr-auto-review behavior-change text. Non-PR events (check_suite, workflow_run) now have a per-event slot, so a later event no longer cancels an in-flight readiness check for the same commit. State what that changes versus the §4b text it replaces and note the [LSP re-pilot placeholder] TypeScript / JavaScript (typescript-language-server / tsgo) — broodly / google-app-scripts / markets #1126 rationale. Keep the pr-review text as is.
  3. §5b / pin notes: record the ci-failure-analyst pin bump.
  4. tests/agent_ingress_markets_package.bats extracts §3 and runs validate-ingress-if.sh and validate-caller-inputs.sh. It must still pass, and any assertion that pins the old group or pin SHA must be updated. The fixtures under tests/fixtures/agent-ingress/markets-pinned-reusables/ need the b5851027… reusable if the collision test reads that pin.

Acceptance criteria

  1. §3 matches the deployed markets agent-ingress.yml exactly (diff the extracted §3 YAML against petry-projects/markets main once feat(pr-review): agent_ref input for pinned self-checkout (#497/#506) #513 merges; zero differing lines).
  2. tests/agent_ingress_markets_package.bats passes in CI.
  3. Only the package doc and its test/fixtures change; no ADR file changes.
  4. The PR body uses Refs, not Closes, for [Phase 3] Collapse the first repo's Class-1 event-driven stubs into agent-ingress.yml and rename the required checks #1729.

Activity

  1. github-actions commented on Oct 10, 2026

    @github-actions
    Contributor

    Thanks for the detailed write-up and for tracking the deployed deviations so precisely. This is a docs-and-tests sync to bring the markets collapse package (§3, §4a/§4b, §5b) and its bats test and fixtures in line with what shipped in combsmith/markets#513. One question before work starts: has markets#513 merged yet, so that we can diff the extracted §3 YAML against main for the zero-differing-lines acceptance check?

  2. don-petry commented on Oct 10, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead Implementation Plan

    Issue: #2171 — Sync the markets collapse package §3/§4b to the deployed ingress (pr-auto-review group + ci-failure-analyst pin)

    Scope

    Bring docs/initiatives/agent-ingress-collapse-markets.md §3 byte-identical to the agent-ingress.yml on markets#513 (head dev-lead/issue-506-20261004-0246). A local diff shows exactly three hunks: the pr-auto-review comment, the pr-auto-review concurrency.group, and the ci-failure-analyst pin. Then update §1/§4a/§4b/§5b prose and the bats test + fixture to match.

    Implementation Checklist

    • §3 YAML: replace the pr-auto-review comment and group with the deployed text, and repin ci-failure-analyst to @b58510275dd1cbbd13c0733c15265d51fd63b992
    • §3 intro / §1 note: mention the deliberate pin carry-over
    • §4a table: update the pr-auto-review leading literal and the ci-failure-analyst pinned ref
    • §4b: rewrite pr-auto-review to describe the per-event slot, what changed from the previous per-SHA text, and the [LSP re-pilot placeholder] TypeScript / JavaScript (typescript-language-server / tsgo) — broodly / google-app-scripts / markets #1126 cross-PR cancellation rationale. pr-review text stays as is
    • §5b: record the bump from 7974717… to b5851027… (carries markets Dependabot bump e390f85). The reusable at the new pin declares no concurrency
    • Fixture tests/fixtures/agent-ingress/markets-pinned-reusables/ci-failure-analyst-reusable.yml: switch PINNED-USES and the snapshot header to b5851027…

    Tests to Write

    • bats: pr-auto-review group is the per-event form (pull_request.number → check_suite.id → workflow_run.id → 'none'), with no head_sha
    • bats: ci-failure-analyst is pinned at b5851027… (existing PINNED-USES tests cover it via the fixture)

    Test Command

    bats tests/agent_ingress_markets_package.bats + bash .dev-lead/scripts/dev-lead-lint.sh

  3. don-petry commented on Oct 10, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead: Progress (in progress — not yet durable)

    Provisional. Nothing is pushed yet; the automation posts the authoritative
    completion record (with PR number + head SHA) after the push. Treat the notes
    below as intent, not delivered results.

    Plan Execution (intended)

    Files touched (this workspace, not yet pushed)

    • docs/initiatives/agent-ingress-collapse-markets.md
    • tests/agent_ingress_markets_package.bats: new test pinning the per-event pr-auto-review group (no head_sha, branch order, literal true)
    • tests/fixtures/agent-ingress/markets-pinned-reusables/ci-failure-analyst-reusable.yml: PINNED-USES moved to b5851027…. The reusable at that SHA still declares no concurrency.

    Notes

  4. don-petry commented on Oct 10, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead: Implementation Complete — PR #2172

    The implementation for issue #2171 is durable: commits are pushed and a pull request is open. This record is backed by verifiable artifacts you can confirm in one click.

    Review happens on the PR. Acceptance criteria and test results are evidenced by the PR's diff and CI checks — not asserted here. If a later stage fails, this claim is retracted in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dev-leadFor dev-lead agent pickupdocumentationDocumentation changes

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions