Skip to content

[#1269 split 2/2] Dispatch the next shadow lane alongside stable + emit shadow_dual_run #1714

Open

Description

@don-petry

Story

As a release manager,
I want the next shadow lane dispatched alongside stable on eligible PRs and the shadow_dual_run signal emitted from the real dual run,
so that a candidate release is validated against live production behaviour before any consumer sees it (initiative #495, SC5).

Split 2 of 2 from #1269. Blocked by the suppression story — dispatching a shadow lane before suppression is proven would post candidate output to real PRs.

Scope

With shadow_mode and total output suppression already landed and tested, turn the second lane on and wire the signal.

Acceptance Criteria

  1. On an eligible PR, the next lane is dispatched in parallel with the stable lane, with shadow_mode: true. Only stable posts — guaranteed by the suppression from split 1, which this story must not weaken or bypass.
  2. Lane concurrency is respected: the shadow lane must not evict or be evicted by the stable lane. The reusable's per-PR / per-SHA lanes exist precisely so unrelated work is not cancelled — give the shadow lane its own key rather than sharing stable's.
  3. scripts/shadow-run.sh is invoked with both lanes' results (STABLE_CONCLUSION, SHADOW_CONCLUSION, output files, run ids) and emits the shadow_dual_run JSON signal. Reuse it as-is — it is already on main from PR feat: implement issue #605 — Shadow-mode dual-run for safe agent canary validation #1252.
  4. Eligibility is explicit and opt-in: shadow dual-run happens only where deliberately enabled. With it off, behaviour is byte-identical to today.
  5. A shadow-lane failure is never allowed to fail the PR's checks or block the stable lane. REGRESSION is a promotion signal, not a PR gate — per docs/release/shadow-mode.md, only the promotion gate consumes it.
  6. Cost is bounded and stated: dual-run doubles agent spend on eligible PRs. The PR description names the eligibility scope and the expected multiplier.
  7. Tests: both lanes dispatched; only stable posts; the signal is emitted with the right status for at least MATCH, REGRESSION and NO_SHADOW; a shadow failure leaves PR checks green.

Tasks / Subtasks

Dev Notes

  • Do not modify shadow-run.sh or shadow-compare.sh. They are the tested comparison + signal half (PR feat: implement issue #605 — Shadow-mode dual-run for safe agent canary validation #1252). This story is dispatch and wiring only.
  • Out of scope: wiring the signal into the promotion gate's consumption path. That gate lives in petry-projects/.github/scripts/canary-rollout.sh — a different repo — and today reads standards/canary-rings.json, with no consumer for gate.signals. Emitting the signal is this story; consuming it is tracked separately. State this exclusion in the PR rather than silently omitting it.
  • Design reference: docs/release/shadow-mode.md — in particular that only REGRESSION blocks promotion and DIVERGED is advisory.
  • Budget: keep dispatch and signal wiring together (they are one behaviour) but nothing more. If it runs long, land dispatch + suppression verification and split the signal emission.

References

Activity

  1. github-actions commented on Sep 8, 2026

    @github-actions
    Contributor

    Thanks for the detailed write-up and for splitting this out cleanly from #1269! Since this is dispatch and wiring work building on suppression already landed, the main thing that would help reviewers most: which workflow file(s) and job steps are the intended insertion points for the parallel next-lane dispatch, and is there a preferred mechanism (e.g., a new uses: step, a matrix, or explicit workflow_dispatch call) given the concurrency-key requirement in AC #2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions