Repository navigation
Description
Story
As the maintainer of the pinning standard,
I want the reusable-pin compliance check (shipped for original-scope #687 by #1449) extended to complete the #1184 legacy → major-scoped channel migration,
so that the canonical pin form is <name>/v<MAJOR>-<tier>, every legacy pin is inventoried and repinned, and enforcement flips only once the migration is provably complete.
Split out of #687 (its ACs 7–13, which lived comment-only and were invisible to the sub-issue DAG). #687's original ACs 1–6 were delivered by #1449 (merged 2026-08-08) and it is closed. The AC numbering below is preserved from the #687 scope-extension comment (2026-08-03) for traceability; that comment holds the full evidence tables (7 legacy vs 10 major-scoped pins, Class A/Class B split).
Acceptance Criteria
- Canonical form corrected. The sanctioned form is the major-scoped channel
<name>/v<MAJOR>-<tier>(tiersstable/next/ring0/ring1) or an immutable<name>/vX.Y.Z. The check must not present bare<name>/<tier>as canonical. - Legacy is classified, not silently passed. A bare
<name>/<tier>ref is reported as DEPRECATED with file, line, and the major-scoped ref it should become. During the migration window this is a warning, not a failure (somainstays green). - Inventory is complete and machine-readable. The check emits every legacy pin across
.github/workflows/**andtemplates/**with counts in the run summary. Expected starting point: 7 legacy / 10 major-scoped (per the [Phase 2] Generalized CI compliance test: reject SHA / # main pins on any first-party reusable #687 extension comment); deviation means the scan missed something. - Class B prerequisite.
pr-review/v1-stableandpr-review/v1-nextare cut viascripts/cut-release.shfrom the commits the current legacy channels point at (tag move, no content change), recorded indocs/release/versioning.md. Do not flip enforcement before this — pr-review has no major-scoped tags, and an early flip failsmainand halts all review via the [Phase 4] pr-review defers indefinitely on another agent's own check run (dev-lead/dispatch) and on zombie checks — ci-pending has no timeout #1427 AC Workflow should skip no-op PRs in MAX_PRS count #7 mechanism. - Repin sweep. All 7 legacy pins repinned to major-scoped equivalents; ring-0 frozen stubs regenerated via
caller_stub_freeze.sh --updatein the same reviewed diff, per AGENTS.md. - Enforcement flip. DEPRECATED becomes a failure as a separate, explicitly-called-out change after ACs 10–11 are complete.
- No reintroduction via the generator. A test asserts a canonical stub pinned
@<name>/v<MAJOR>-stableround-trips throughseed-repo-template.shunchanged. Supersedes [bug] seed-repo-template.sh repins caller stubs to pre-#1184 legacy channels — template-drift enforces a baseline that contradicts standards #1436 AC feat: add Copilot engine support via REVIEW_ENGINE toggle #5; the guard [bug] seed-repo-template fetches standards unpinned — pin to published stable, compliance accepts N-1 (continues #1436) #1448 should reference.
Tasks / Subtasks
- Amend the classifier: major-scoped = sanctioned, bare tier = DEPRECATED + suggested replacement. (AC: 7, 8)
- Emit inventory + counts in the run summary. (AC: 9)
- Cut
pr-review/v1-stable+pr-review/v1-nextat the current legacy channel commits. (AC: 10) - Repin the 7 legacy refs; regenerate frozen baselines in the same diff. (AC: 11)
- Flip DEPRECATED → failure as a discrete change. (AC: 12)
- Add the generator round-trip test. (AC: 13)
- Update AGENTS.md "Release channel tags" examples to major-scoped form, marking bare
<name>/<tier>legacy.
Dev Notes
- Full evidence, pin tables, and the Class A/Class B analysis live in [Phase 2] Generalized CI compliance test: reject SHA / # main pins on any first-party reusable #687's scope-extension comment (2026-08-03T02:44Z) — read it before starting.
- Cutting a channel is a tag move at existing commits, behaviourally inert and independently revertible.
- The compliance check itself lives at
tests/dev-lead/integration/test_reusable_pin_compliance.pywith its CI job intest-dev-lead.yml(landed via feat: implement issue #687 — [Phase 2] Generalized CI compliance test: reject SHA / # main pins on any first-party reusable #1449). - AGENTS.md's mutable-ref exception covers both forms; the distinction throughout is canonical vs deprecated, never sanctioned vs unsanctioned.
References
- Predecessor: [Phase 2] Generalized CI compliance test: reject SHA / # main pins on any first-party reusable #687 (original scope; closed), feat: implement issue #687 — [Phase 2] Generalized CI compliance test: reject SHA / # main pins on any first-party reusable #1449 (merged implementation)
- Channel scheme: F2: cut-release.sh learns v<major>-<tier> channels [#657] #1184; ordering hazard: feat: implement issue #1031 — fix(#844): plumb LSP_PILOT_ENABLED env + decouple capture from LSP wiring so the pilot A/B runs in CI #1034, [Phase 4] pr-review defers indefinitely on another agent's own check run (dev-lead/dispatch) and on zombie checks — ci-pending has no timeout #1427 AC Workflow should skip no-op PRs in MAX_PRS count #7
- Related guards: [bug] seed-repo-template.sh repins caller stubs to pre-#1184 legacy channels — template-drift enforces a baseline that contradicts standards #1436, [bug] seed-repo-template fetches standards unpinned — pin to published stable, compliance accepts N-1 (continues #1436) #1448
- Epic: Formalize the agentic PR-interaction model (event-first, timers-as-backstop) — clear, repeatable, enforceable #1402
Activity
don-petry commentedon Aug 18, 2026
Dev-Lead Implementation Plan
Issue: #1493 — [Phase 2 follow-up] Complete the #1184 legacy→major-scoped pin migration in the reusable-pin compliance check
Scope
Amend the reusable-pin compliance check so the major-scoped channel
<name>/v<MAJOR>-<tier>(and immutable<name>/vX.Y.Z) is the only sanctioned canonical form, classify bare<name>/<tier>as DEPRECATED (a warning during the migration window, gated by a single explicit enforcement toggle somainstays green), emit a machine-readable legacy-vs-major-scoped inventory, repin the one currently-unblocked legacy pin, and add the generator round-trip guard.Current-state findings (deviation from the #687-era 7/10)
pr-review/next(.github/workflows/pr-review-trigger.yml, a frozen ring-0 stub) andci-failure-analyst/stable(templates/ci-failure-analyst.yml).ci-failure-analyst/v1-stablealready exists (used byci-failure-analyst.lock.yml+ freeze baseline) → the template repin is unblocked.pr-reviewhas no major-scoped tags yet (the AC fix: skip no-op PRs from MAX_PRS budget in pr-review workflow #10 Class-B prerequisite) → repinning it would break the reusable at runtime, so it stays a DEPRECATED warning until the tags are cut. The DEPRECATED-as-warning design is exactly what keepsmaingreen here.Implementation Checklist
tests/dev-lead/integration/test_reusable_pin_compliance.py— split sanctioning: major-scoped/semver = canonical; bare<name>/<tier>= DEPRECATED with a suggested major-scoped replacement; keep SHA/off-channel/unsanctioned = fatal. (AC 7, 8)ENFORCE_DEPRECATEDtoggle (default off = warning) so the AC 12 enforcement flip is a one-line, explicitly-called-out later change. (AC 8, 12)$GITHUB_STEP_SUMMARY. (AC 9)templates/ci-failure-analyst.ymlci-failure-analyst/stable→ci-failure-analyst/v1-stable(unblocked half of AC 11).docs/release/versioning.md/AGENTS.md— mark bare<name>/<tier>as the deprecated pre-F2: cut-release.sh learns v<major>-<tier> channels [#657] #1184 legacy form; keep examples major-scoped. (AC 7 + final task).github/workflows/test-dev-lead.yml— run the new classifier unit test in thereusable-pin-compliancejob.Tests to Write (TDD first)
tests/dev-lead/integration/test_reusable_pin_classifier.py— asserts:v1-stable/vX.Y.Z= ok;pr-review/next= DEPRECATED (non-fatal now, fatal whenENFORCE_DEPRECATED); SHA/main/garbage = fatal; suggested replacement mapping; inventory counts on temp fixtures.tests/test_seed_repo_template.bats— a canonical stub pinned@<name>/v<MAJOR>-stableround-trips throughseed-repo-template.sh --repinunchanged (AC 13, supersedes [bug] seed-repo-template.sh repins caller stubs to pre-#1184 legacy channels — template-drift enforces a baseline that contradicts standards #1436 AC 5).Explicitly out of scope here (live-git / separate-change per the ACs)
pr-review/v1-stable+pr-review/v1-next(requires live tag operations; no commits/tags from this agent).pr-review/next, blocked on AC 10; frozen-stub regen deferred with it.Test Command
python3 tests/dev-lead/integration/test_reusable_pin_classifier.py && python3 tests/dev-lead/integration/test_reusable_pin_compliance.py && bats tests/test_seed_repo_template.batsdon-petry commentedon Aug 18, 2026
Dev-Lead: issue #1493 implementation failed — will retry
The engine failed (
engine-error— e.g. a timeout or transient engine error). This was attempt 1 of 3; dev-lead will retry automatically. You can also re-apply thedev-leadlabel to retry now.engine-errorLast 40 lines of engine output (redacted)
don-petry commentedon Aug 18, 2026
Dev-Lead: issue #1493 implementation failed — will retry
The engine failed (
engine-error— e.g. a timeout or transient engine error). This was attempt 2 of 3; dev-lead will retry automatically. You can also re-apply thedev-leadlabel to retry now.engine-errorLast 40 lines of engine output (redacted)
don-petry commentedon Aug 18, 2026
Dev-Lead Implementation Plan
Issue: #1493 — [Phase 2 follow-up] Complete the #1184 legacy→major-scoped pin migration in the reusable-pin compliance check (split from #687 ACs 7–13)
Current-state finding
The 2026-08-03 evidence (7 legacy / 10 major-scoped) is stale. As of today the in-scope scanner
surface has 2 legacy bare-tier pins left:
.github/workflows/pr-review-trigger.yml→pr-review.yml@pr-review/nexttemplates/ci-failure-analyst.yml→ci-failure-analyst-reusable.yml@ci-failure-analyst/stableEvery other first-party pin is already major-scoped (
<name>/v<MAJOR>-<tier>).Scope (this PR — the green, self-contained slice)
Correct the compliance check to make major-scoped canonical and bare
<name>/<tier>aDEPRECATED warning (not a failure, so
mainstays green) with a full machine-readable inventory,plus the generator round-trip guard and the doc update.
Implementation Checklist
tests/dev-lead/integration/test_reusable_pin_compliance.py— amend classifier: major-scoped/semver/@vN= canonical; bare<name>/<tier>= DEPRECATED (warning, not failure) with file, line, and suggested<name>/v<MAJOR>-<tier>replacement (AC 7, 8)$GITHUB_STEP_SUMMARY(AC 9)templates/ci-failure-analyst.yml— repin the one unblocked legacy pin toci-failure-analyst/v1-stable(the major-scoped tag already exists; used byci-failure-analyst.lock.yml) — partial AC 11AGENTS.md— mark bare<name>/<tier>as the deprecated legacy form, major-scoped as canonical (AC 7 task).github/workflows/test-dev-lead.yml— wire the new classifier test stepTests to Write (before implementation)
tests/dev-lead/integration/test_reusable_pin_compliance_classifier.py— canonical vs DEPRECATED vs violation classification, line-number capture, warning-not-failure exit code, inventory countstests/test_seed_repo_template.bats— a canonical stub pinned@<name>/v<MAJOR>-stableround-trips throughseed-repo-template.sh --repinunchanged (AC 13; supersedes [bug] seed-repo-template.sh repins caller stubs to pre-#1184 legacy channels — template-drift enforces a baseline that contradicts standards #1436 AC feat: add Copilot engine support via REVIEW_ENGINE toggle #5)Explicitly deferred (require operations an automated PR must not perform; sequenced later)
pr-review/v1-stable+pr-review/v1-next: pushes release/channel tags to the remote, gated by the admin-onlyrelease-channel-tagsruleset. Cannot be done from an automated dev-lead PR (no tag push).pr-review-trigger.ymlis blocked on AC 10: pr-review has no major-scoped tags yet, so repinning now would fail post-merge (validate-caller-inputs/ the [#1052 D] Baseline hygiene: actionlint + pr-review startup_failure canary (blocked on #1253) #1256 canary). Left as a DEPRECATED warning — exactly the migration-window behavior AC 8 specifies.mainwhilepr-review/nextis still legacy.Test Command
python3 tests/dev-lead/integration/test_reusable_pin_compliance.py,python3 tests/dev-lead/integration/test_reusable_pin_compliance_classifier.py,bats tests/test_seed_repo_template.bats,bash .dev-lead/scripts/dev-lead-lint.shdon-petry commentedon Aug 18, 2026
Dev-Lead: Implementation Complete
Implemented the green, self-contained slice of the #1184 legacy→major-scoped migration in the
reusable-pin compliance check — the classifier/inventory correction, the generator round-trip guard,
and the doc update — while keeping
maingreen. The tag-cutting / enforcement-flip ACs are deferred(see Deferred), consistent with the issue's own sequencing (AC 8 warning-window, AC 12 "separate,
later change after ACs 10–11").
Current-state finding
The 2026-08-03 evidence (7 legacy / 10 major-scoped) is stale; the migration has since progressed. The
scanner now reports 13 canonical / 1 legacy of 14 in-scope pins. The only legacy pin left is
pr-review-trigger.yml → @pr-review/next, which is blocked on AC 10 (pr-review has no major-scoped tags yet).Plan Execution
@vNare canonical; bare<name>/<tier>is no longer presented as canonical.<name>/<tier>classified DEPRECATED with file, line, and suggested<name>/v<MAJOR>-<tier>; a warning, not a failure (exit 0,mainstays green).$GITHUB_STEP_SUMMARY(markdown table of every legacy pin).templates/ci-failure-analyst.ymlto@ci-failure-analyst/v1-stable(that major-scoped tag already exists — used byci-failure-analyst.lock.yml). Also updated thedocs/aw/ci-failure-analyst.mdarchitecture diagram to match.@<name>/v<MAJOR>-stablestub passes throughseed-repo-template.sh --repinbyte-for-byte unchanged (supersedes [bug] seed-repo-template.sh repins caller stubs to pre-#1184 legacy channels — template-drift enforces a baseline that contradicts standards #1436 AC feat: add Copilot engine support via REVIEW_ENGINE toggle #5).<name>/<tier>as the DEPRECATED legacy form and major-scoped as canonical, with examples.test-dev-lead.yml.Deferred (require operations an automated PR must not perform; sequenced later)
pr-review/v1-stable+pr-review/v1-next: pushes release/channel tags to the remote, gated by the admin-onlyrelease-channel-tagsruleset. Not doable from an automated dev-lead PR (no tag push).pr-review-trigger.ymlis blocked on AC 10; repinning to a non-existentpr-review/v1-nextwould fail post-merge (validate-caller-inputs/ the [#1052 D] Baseline hygiene: actionlint + pr-review startup_failure canary (blocked on #1253) #1256 canary). It remains a DEPRECATED warning — exactly AC 8's migration-window behavior. No frozen-stub regen needed since the ring-0 stub is untouched.mainwhilepr-review/nextis still legacy.Test Results
Files Changed
tests/dev-lead/integration/test_reusable_pin_compliance.py: canonical vs DEPRECATED-legacy vs violation classifier; line-number capture; inventory + counts to run summary; deprecations are warnings (exit 0).tests/dev-lead/integration/test_reusable_pin_compliance_classifier.py(new): classifier/CLI behavior tests (canonical/deprecated/violation, line capture, warning-not-failure, SHA still fails, summary counts).tests/test_seed_repo_template.bats: AC 13 round-trip idempotency guard.templates/ci-failure-analyst.yml: repin@ci-failure-analyst/stable→@ci-failure-analyst/v1-stable.docs/aw/ci-failure-analyst.md: diagram pin updated to match.AGENTS.md: bare-tier marked DEPRECATED-legacy; major-scoped canonical + examples..github/workflows/test-dev-lead.yml: new classifier test step.Notes
test_seed_repo_template.bats(50 tests),template_stub_drift.bats, the classifier test, the scanner against the repo, anddev-lead-lint.sh(shellcheck on 110 files + agent-profile validation) all pass.<name>/v<MAJOR>-<tier>(not a concrete major) because a static scan cannot know the major line without querying tags.chore: empty commit to retrigger review — cycle-1 blocking finding wa…
feat: implement issue #1493 — [Phase 2 follow-up] Complete the #1184 …
don-petry commentedon Aug 19, 2026
Dev-Lead Implementation Plan
Issue: #1493 — [Phase 2 follow-up] Complete the #1184 legacy→major-scoped pin migration in the reusable-pin compliance check (split from #687 ACs 7–13)
Scope
Complete the Class B tail of the #1184 migration: repin the last remaining legacy pin (
pr-review-trigger.yml@pr-review/next) to the major-scoped@pr-review/v1-next, regenerate the frozen ring-0 stub baseline, record the pr-review channel cut in the versioning doc, and flip the reusable-pin compliance check so a bare<name>/<tier>pin is now a hard failure (guarding against reintroduction).Current state (already delivered upstream, verified)
test_reusable_pin_compliance.py+test_reusable_pin_compliance_classifier.py.tests/test_seed_repo_template.bats.pr-review-trigger.yml:63 @pr-review/next.pr-review/v1-stableandpr-review/v1-nextdo not yet exist on the remote (only legacypr-review/next@ded84ce4,pr-review/stable@8e00cde6). Before this PR merges, a maintainer / promotion App must cut them at the current legacy-channel commits (behaviourally inert tag creation), e.g.:The repin below resolves
@pr-review/v1-nextat runtime only after this cut. Merging the repin before the cut wouldstartup_failurethe ring-0 pr-review workflow and halt all review in this repo (#1034 / #1427 AC#7). CI itself stays green either way (the compliance scan is static;validate-caller-inputssoft-passes an unresolved channel with a::warning::).Implementation Checklist
docs/release/versioning.md— recordpr-review/v1-stable+pr-review/v1-nextas cut at the legacy-channel commits (AC10)..github/workflows/pr-review-trigger.yml— repinuses:+agent_ref:@pr-review/next→@pr-review/v1-next; update the header comment (AC11).tests/fixtures/caller-stub-freeze/pr-review-trigger.block— regenerate viascripts/caller_stub_freeze.sh --update(AC11).tests/dev-lead/integration/test_reusable_pin_compliance.py— flip DEPRECATED → failure; refresh docstring/summary text (AC12).Tests to Write / Update (TDD before impl)
test_reusable_pin_compliance_classifier.py— fliptest_cli_deprecated_is_warning_not_failureandtest_nested_workflow_included_in_inventoryto assert a legacy-only file now exits 1 while still inventorying it as DEPRECATED; keep classification (classify_ref/scan_file) tests intact.Test Command
python3 tests/dev-lead/integration/test_reusable_pin_compliance_classifier.py && python3 tests/dev-lead/integration/test_reusable_pin_compliance.py && bats tests/caller_stub_freeze.bats tests/test_seed_repo_template.batsdon-petry commentedon Aug 19, 2026
Dev-Lead: Implementation Complete — PR #1545
The implementation for issue #1493 is durable: commits are pushed and a pull request is open. This record is backed by verifiable artifacts you can confirm in one click.
2180f5ef9555a6a0591a40ca5c86cb1b2bafaea2Review happens on the PR. Acceptance criteria and test results are evidenced by the PR's diff and CI checks — not asserted here. If a later stage fails, this claim is retracted in place.
don-petry commentedon Aug 20, 2026
fix(reviews): AGENTS.md channel-tag updates + doc/test accuracy (stee…
feat: implement issue #1493 — [Phase 2 follow-up] Complete the #1184 …