You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ruleset pr-quality parameter dismiss_stale_reviews_on_push has drifted from the codified standard: expected true, actual false. The codified JSON (standards/rulesets/pr-quality.json) is the source of truth (#575/#580); run scripts/apply-rulesets.sh --repo petry-projects/.github-private to converge.
Converge the livepr-quality branch ruleset on petry-projects/.github-private so dismiss_stale_reviews_on_push matches the codified source of truth (true), fixing the sole drifted parameter named in the finding.
Analysis (why this is not a repo code change)
pr-quality is a live GitHub repository ruleset (id 16142042), not a file tracked in this repo.
The codified source of truth standards/rulesets/pr-quality.json lives in the public petry-projects/.github repo and already prescribes dismiss_stale_reviews_on_push: true — nothing in the standard is wrong.
The remediation helper scripts/apply-rulesets.sh also lives in the public repo; neither file exists in .github-private.
Confirmed drift: live ruleset currently has dismiss_stale_reviews_on_push: false.
Therefore the remediation is an operational settings convergence against live GitHub, with no source file to modify in this repo → no code diff and no PR will be produced.
Implementation Checklist
Capture before-state of the live pr-quality ruleset (evidence).
Surgically PATCH the ruleset: flip onlydismiss_stale_reviews_on_pushfalse → true, preserving every other live parameter/bypass-actor (scope-limited to the finding; require_last_push_approval drift, if any, is out of scope for Compliance: ruleset-drift-pr-quality-dismiss_stale_reviews_on_push #1478).
Read back the live ruleset and confirm convergence.
Tests to Write
N/A — this is a live GitHub settings change with no repo code artifact. Per the dev-lead Phase-2 exception (config/settings change, no observable code behavior), TDD is skipped. Verification is a live API read-back diff (before/after) instead.
Test Command
gh api repos/petry-projects/.github-private/rulesets/16142042 (read-back verification; no repo test suite applies)
Compliance finding resolved. The live pr-quality branch ruleset on petry-projects/.github-private now matches the codified source of truth for the drifted parameter.
dismiss_stale_reviews_on_push: false → true ✅
Plan Execution
Analyzed finding: pr-quality is a live GitHub ruleset (id 16142042), not a repo-tracked file. The codified source of truth (standards/rulesets/pr-quality.json) and the remediation helper (scripts/apply-rulesets.sh) both live in the public petry-projects/.github repo — neither exists in this repo, and the codified standard already prescribes true. So the fix is an operational convergence of live settings, not a code change.
Captured before-state evidence of the live ruleset.
Applied a surgical ruleset update: flipped only dismiss_stale_reviews_on_pushfalse → true, preserving every other live parameter and both bypass actors.
[lint] shellcheck on 102 file(s)...
[lint] validating 4 agent profile(s)...
[lint] validating .github/CODEOWNERS...
[lint] all checks passed
Files Changed
None. This finding has no repo-tracked artifact. The remediation is a live GitHub repository-settings change (ruleset id 16142042), applied via the GitHub API by an admin identity (don-petry). Consequently there is no code diff and no PR — the CI git-operation step will find an empty working tree, which is expected for a settings-only convergence.
Notes / Scope
Phase 2 (TDD) skipped under the documented exception for configuration/settings changes with no observable code behavior. Verification is a before/after live API read-back instead of a unit test.
Scope was held to the single named parameter. The codified JSON also prescribes require_last_push_approval: true while the live ruleset has false. That is a separate potential drift not named in this finding, so it was intentionally left unchanged to avoid implementing more than Compliance: ruleset-drift-pr-quality-dismiss_stale_reviews_on_push #1478 requests. If it should also converge, it warrants its own compliance finding/issue.
Reversibility: the change is a stricter review requirement (dismiss stale approvals on push) and is trivially reversible by flipping the same parameter back.
Follow-up: if desired, resolving the require_last_push_approval divergence would fully converge pr-quality to the codified JSON.
Activity
don-petry commentedon Aug 7, 2026
Dev-Lead Implementation Plan
Issue: #1478 — Compliance: ruleset-drift-pr-quality-dismiss_stale_reviews_on_push
Scope
Converge the live
pr-qualitybranch ruleset onpetry-projects/.github-privatesodismiss_stale_reviews_on_pushmatches the codified source of truth (true), fixing the sole drifted parameter named in the finding.Analysis (why this is not a repo code change)
pr-qualityis a live GitHub repository ruleset (id16142042), not a file tracked in this repo.standards/rulesets/pr-quality.jsonlives in the publicpetry-projects/.githubrepo and already prescribesdismiss_stale_reviews_on_push: true— nothing in the standard is wrong.scripts/apply-rulesets.shalso lives in the public repo; neither file exists in.github-private.dismiss_stale_reviews_on_push: false.Implementation Checklist
pr-qualityruleset (evidence).dismiss_stale_reviews_on_pushfalse → true, preserving every other live parameter/bypass-actor (scope-limited to the finding;require_last_push_approvaldrift, if any, is out of scope for Compliance: ruleset-drift-pr-quality-dismiss_stale_reviews_on_push #1478).Tests to Write
Test Command
gh api repos/petry-projects/.github-private/rulesets/16142042(read-back verification; no repo test suite applies)don-petry commentedon Aug 7, 2026
Dev-Lead: Implementation Complete
Outcome
Compliance finding resolved. The live
pr-qualitybranch ruleset onpetry-projects/.github-privatenow matches the codified source of truth for the drifted parameter.dismiss_stale_reviews_on_push:false→true✅Plan Execution
pr-qualityis a live GitHub ruleset (id16142042), not a repo-tracked file. The codified source of truth (standards/rulesets/pr-quality.json) and the remediation helper (scripts/apply-rulesets.sh) both live in the publicpetry-projects/.githubrepo — neither exists in this repo, and the codified standard already prescribestrue. So the fix is an operational convergence of live settings, not a code change.dismiss_stale_reviews_on_pushfalse → true, preserving every other live parameter and both bypass actors.Verification (live API read-back)
Before:
After:
Lint gate:
Files Changed
16142042), applied via the GitHub API by an admin identity (don-petry). Consequently there is no code diff and no PR — the CI git-operation step will find an empty working tree, which is expected for a settings-only convergence.Notes / Scope
require_last_push_approval: truewhile the live ruleset hasfalse. That is a separate potential drift not named in this finding, so it was intentionally left unchanged to avoid implementing more than Compliance: ruleset-drift-pr-quality-dismiss_stale_reviews_on_push #1478 requests. If it should also converge, it warrants its own compliance finding/issue.require_last_push_approvaldivergence would fully convergepr-qualityto the codified JSON.don-petry commentedon Aug 14, 2026
Resolved! This check is now passing as of 2026-08-14. Closing automatically.