Repository navigation
Description
Problem
Lint fails on PR #1449 with errors from node_modules/bats/README.md — a vendored dependency's README that no PR authored. #1449 touches zero markdown files.
node_modules/bats/README.md:9:1 MD033/no-inline-html Inline HTML [Element: div]
node_modules/bats/README.md:59:3 MD004/ul-style Unordered list style
node_modules/bats/README.md:59:5 MD051/link-fragments Link fragments should be valid
…
Cause: .markdownlint-cli2.jsonc ignores only .claude/**, frameworks/**, prompts/**. node_modules/** is not ignored — and node_modules is not in .gitignore either. So whenever node_modules/ exists on the runner at the time markdownlint runs, it lints third-party package docs and fails on style rules those packages were never written against.
Why this is more than a lint nuisance
A red Lint is not a required check, but compute_ci_status (scripts/lib/ci-status.sh) has no required/non-required notion — any failing check makes it return failing, and review-one-pr.sh:141 then skips the review silently, posting nothing on the PR. That is #1427 AC #7.
So this defect silently halts pr-review on any PR it hits. That exact failure mode cost roughly six hours of zero merges earlier today via a different red check (template-drift, #1435/#1436). This is a second, independent trigger for the same halt.
It is currently blocking #1449, which implements #687 — itself the blocker for completing the #1184 channel migration.
Acceptance Criteria
node_modules/**is excluded from markdown linting — added to theignoresarray in.markdownlint-cli2.jsonc.node_modules/is added to.gitignore, so a local install can never be committed and never enters a diff.Lintpasses on a PR whose CI hasnode_modules/present on the runner; feat: implement issue #687 — [Phase 2] Generalized CI compliance test: reject SHA / # main pins on any first-party reusable #1449 is the regression case.- The ignore list is reviewed for the same class of gap — any other directory populated by a package manager or vendored at build time (not just
node_modules) is excluded, so this does not recur under a different name. - No repo-authored markdown is newly exempted: the change must not silence lint on files this repo actually owns. Diff the pre/post file set that markdownlint evaluates and confirm only third-party paths are removed.
Tasks / Subtasks
- Add
node_modules/**to.markdownlint-cli2.jsoncignores. (AC: test issue from agent #1) - Add
node_modules/to.gitignore. (AC: Go-live improvements for PR review agent #2) - Confirm
Lintgoes green on feat: implement issue #687 — [Phase 2] Generalized CI compliance test: reject SHA / # main pins on any first-party reusable #1449. (AC: Add @claude delegation, auto-merge, and rebase handling #3) - Audit the ignore list for other build-populated paths. (AC: Optimize review: small-PR and incremental fast paths #4)
- Record the before/after evaluated-file set in the PR to prove no owned file was exempted. (AC: feat: add Copilot engine support via REVIEW_ENGINE toggle #5)
Dev Notes
- Keep the fix to exclusion, not rule-relaxation. Disabling MD033/MD004/MD051 repo-wide to silence a vendored README would weaken linting on files we do own — AC feat: add Copilot engine support via REVIEW_ENGINE toggle #5 exists to make that explicit.
- The existing
ignoresentries (.claude/**,frameworks/**,prompts/**) are the precedent:frameworks/**is already excluded as vendored upstream content, which is exactly the categorynode_modules/**falls into. This is completing an existing pattern, not inventing one. - Worth noting the asymmetry that made this hard to spot:
Lintpasses on chore: sync 4 org-standard workflow stub(s) from petry-projects/.github #1378 and feat: implement issue #1291 — Compliance: missing-permissions-dismiss-stale-bot-reviews.yml #1292 but fails on feat: implement issue #687 — [Phase 2] Generalized CI compliance test: reject SHA / # main pins on any first-party reusable #1449, so it presents as PR-specific when it is environmental — the ordering of whatever createsnode_modules/on the runner decides it.
References
.markdownlint-cli2.jsonc(ignoresarray).gitignore(nonode_modulesentry)scripts/lib/ci-status.sh,scripts/review-one-pr.sh:141(why a non-required red check halts review)- [Phase 4] pr-review defers indefinitely on another agent's own check run (dev-lead/dispatch) and on zombie checks — ci-pending has no timeout #1427 AC Workflow should skip no-op PRs in MAX_PRS count #7 (the silent-skip half), [bug] Dependabot bumps in repo-template break template-drift — a byte-identity distribution artifact is being edited directly, silently halting all PR review here #1435/[bug] seed-repo-template.sh repins caller stubs to pre-#1184 legacy channels — template-drift enforces a baseline that contradicts standards #1436 (the earlier instance of this halt)
- Observed on PR feat: implement issue #687 — [Phase 2] Generalized CI compliance test: reject SHA / # main pins on any first-party reusable #1449, Lint run 30781010403
Activity
don-petry commentedon Aug 3, 2026
Dev-Lead Implementation Plan
Issue: #1450 — [bug] markdownlint lints node_modules/ — vendored READMEs fail Lint, silently halting pr-review
Scope
Exclude
node_modules/(and other package-manager/build-populated dirs) from markdownlint so third-party/vendored READMEs never failLint, and gitignorenode_modules/so an install can't be committed — completing the existingframeworks/**/prompts/**vendored-exclusion pattern.Implementation Checklist
node_modules/**to theignoresarray in.markdownlint-cli2.jsonc(AC test issue from agent #1)scripts/seed-repo-template.sh:vendor,dist,build,coverage) so it can't recur under a different name (AC Optimize review: small-PR and incremental fast paths #4)node_modules/to the per-repo section of.gitignore(AC Go-live improvements for PR review agent #2)Tests to Write
node_modules/**paths drop out — zero repo-owned.mdfiles newly exempted (AC Add @claude delegation, auto-merge, and rebase handling #3, AC feat: add Copilot engine support via REVIEW_ENGINE toggle #5)Test Command
bash .dev-lead/scripts/dev-lead-lint.sh+scripts/run-bats.sh(repo lint/test suite); markdownlint evaluated-set diff for AC #5don-petry commentedon Aug 3, 2026
Dev-Lead: Implementation Complete
Plan Execution
node_modules/**to theignoresarray in.markdownlint-cli2.jsonc(AC test issue from agent #1)vendor/**,dist/**,build/**,coverage/**— the package-manager/build-output dirs the org repo-template already treats as dependency/build output (scripts/seed-repo-template.sh:203,214-217), so it can't recur under a different name (AC Optimize review: small-PR and incremental fast paths #4)node_modules/to the per-repo section of.gitignore(AC Go-live improvements for PR review agent #2)Lintgoes green withnode_modules/present, and that the evaluated-file set loses only third-party paths (AC Add @claude delegation, auto-merge, and rebase handling #3, AC feat: add Copilot engine support via REVIEW_ENGINE toggle #5)Test Results
Reproduction + fix proof (markdownlint-cli2 v0.23.2 / markdownlint v0.41.1, run with
node_modules/present on disk — the #1449 condition):Evaluated-file-set diff (AC #5): 116 → 113 files. The three files removed are all third-party:
node_modules/bats/README.md,node_modules/bats/LICENSE.md,node_modules/bats/man/README.md.No repo-owned markdown is newly exempted — confirmed there is zero
.mdunder anyvendor/,dist/,build/, orcoverage/path in the tree, so the AC #4 preventive globs remove nothing today; theyonly guard the future.
Required repo lint:
Relevant unit suite (
.gitignore-emitting logic — vendored bats 1.13.0):(The full
run-bats.shlist fromlint.ymlwas not exercised locally: no test references either changedfile, the change is config-only, and most suites require
gh/network.dev-lead-lint.sh— the requiredgate — passes.)
Files Changed
.markdownlint-cli2.jsonc: addednode_modules/**,vendor/**,dist/**,build/**,coverage/**toignores, completing the existing vendored-exclusion pattern (frameworks/**,prompts/**)..gitignore: addednode_modules/to the per-repo (non-baseline) section.Notes
node_modules/is currently tracked in git (33 files undernode_modules/bats/, committed onmain). This change stops future commits and stops linting them, satisfying all five ACs, but a.gitignoreentry does not untrack already-committed files. Agit rm -r --cached node_modules(leaving the working copy) would fully honor AC Go-live improvements for PR review agent #2's "never enters a diff" intent. I did not include it here because it is outside this issue's stated two-file scope and touches git tracking of files this issue did not enumerate — flagging it for a human decision.feat: implement issue #1450 — [bug] markdownlint lints node_modules/ …
feat: implement issue #1450 — [bug] markdownlint lints node_modules/ …