Skip to content

auto-rebase: fix repo-template's orphaned channel pin + AGENTS.md doc drift (AC6) #1439

Closed

Description

@don-petry

Part of #1416 (AC6).

  • scripts/seed-repo-template.sh's WORKFLOW_MANIFEST hardcodes the auto-rebase caller stub it seeds into new repos as pinned to the legacy, orphaned auto-rebase/stable tag (verified at commit 1a186e9c…, older than every currently-deployed v2-* channel at 837cee9d…). scripts/cut-release.sh never moves that tag — only <agent>/v<MAJOR>-<tier> refs — so it will never catch up on its own. Update the manifest entry to pin the current major-scoped stable channel (auto-rebase/v2-stable, or whatever is current when this ships) instead.
  • Separately, AGENTS.md's description of this repo's own auto-rebase.yml pin (@auto-rebase/stable) doesn't match the actual file (auto-rebase/v2-next). Correct the doc to describe the actual pin.

See #1416 § "6. Channel-pin drift" for full detail.

Activity

  1. github-actions commented on Aug 2, 2026

    @github-actions
    Contributor

    Thanks for the detailed write-up and for tracing this all the way back to the commit where the drift was introduced — that context makes the fix much easier to reason about. To make sure the WORKFLOW_MANIFEST patch lands on the right value: can you confirm which channel ref should be the authoritative replacement for auto-rebase/stable at the time this ships — is auto-rebase/v2-stable already live and the intended target, or should the manifest point to auto-rebase/v2-next to stay consistent with what auto-rebase.yml currently uses in this repo?

  2. don-petry commented on Aug 2, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead Implementation Plan

    Issue: #1439 — auto-rebase: fix repo-template's orphaned channel pin + AGENTS.md doc drift (AC6)

    Scope

    Correct AGENTS.md's stale description of this repo's auto-rebase.yml pin; the seed-template manifest half of this issue was already resolved by #1436.

    Findings / Scope narrowing

    • Part 1 — scripts/seed-repo-template.sh WORKFLOW_MANIFEST orphaned pin: Already fixed by [bug] seed-repo-template.sh repins caller stubs to pre-#1184 legacy channels — template-drift enforces a baseline that contradicts standards #1436 (commit d14a702). The manifest no longer hardcodes a channel per stub; the row is now auto-rebase|caller|petry-projects/.github and the channel is derived from the canonical stub's own major-scoped uses: ref via _derive_stable_channel, yielding auto-rebase/v2-stable. The existing test tests/test_seed_repo_template.bats (repin case) already asserts the repin outputs @auto-rebase/v2-stable and never the legacy @auto-rebase/stable. No source change required here.
    • Part 2 — AGENTS.md doc drift: AGENTS.md line 34 states auto-rebase.yml pins @auto-rebase/stable, but the actual file (.github/workflows/auto-rebase.yml) pins @auto-rebase/v2-next (enforced by tests/dev-lead/integration/test_auto_rebase_stub.py, EXPECTED_REF = "@auto-rebase/v2-next"). This is the remaining fix.

    Implementation Checklist

    • AGENTS.md: correct the auto-rebase pin reference @auto-rebase/stable → @auto-rebase/v2-next, and fix the now-inaccurate "matching the canonical org stub" clause (this repo dogfoods the v2-next channel ahead of the canonical @auto-rebase/next stub, per the enforcing test's docstring).

    Tests to Write

    • None. This is a pure documentation correction (Phase 2 TDD exception). The behavioral pin is already guarded by test_auto_rebase_stub.py (actual file) and test_seed_repo_template.bats (seed manifest); both pass on the current baseline.

    Test Command

    python3 tests/dev-lead/integration/test_auto_rebase_stub.py + bash .dev-lead/scripts/dev-lead-lint.sh

  3. don-petry commented on Aug 2, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead: Implementation Complete

    Plan Execution

    • Part 1 (seed manifest orphaned pin): Verified already resolved by [bug] seed-repo-template.sh repins caller stubs to pre-#1184 legacy channels — template-drift enforces a baseline that contradicts standards #1436 (commit d14a702) — no source change needed. WORKFLOW_MANIFEST no longer hardcodes a channel; auto-rebase|caller|petry-projects/.github derives auto-rebase/v2-stable via _derive_stable_channel, and tests/test_seed_repo_template.bats already asserts the repin emits @auto-rebase/v2-stable and never the legacy @auto-rebase/stable.
    • Part 2 (AGENTS.md doc drift): Corrected AGENTS.md — the auto-rebase pin reference now reads @auto-rebase/v2-next (the actual file pin) and the previously-inaccurate "matching the canonical org stub" clause now correctly describes this repo dogfooding the v2-next channel ahead of the canonical @auto-rebase/next stub.

    Test Results

    === tests/dev-lead/integration/test_auto_rebase_stub.py ===
    PASS: .github/workflows/auto-rebase.yml correctly references petry-projects/.github/.github/workflows/auto-rebase-reusable.yml@auto-rebase/v2-next
    exit=0
    
    === .dev-lead/scripts/dev-lead-lint.sh (required) ===
      [lint] shellcheck on 102 file(s)...
      [lint] validating 4 agent profile(s)...
      OK: agents/agentic-workflows.md, compliance-auditor.md, feature-ideator.md, pr-reviewer.md
      [lint] validating .github/CODEOWNERS... OK
      [lint] all checks passed
    lint exit=0
    

    Files Changed

    • AGENTS.md: fixed the stale auto-rebase pin description (@auto-rebase/stable → @auto-rebase/v2-next) and corrected the "matching the canonical org stub" framing to reflect this repo riding the v2-next dogfood channel ahead of the canonical @auto-rebase/next stub.

    Notes

    • TDD Phase 2 exception: This is a pure documentation correction with no observable behavioral change, so no new failing test was written. The behavioral pin remains guarded by test_auto_rebase_stub.py (actual workflow file, EXPECTED_REF = @auto-rebase/v2-next) and the seed-manifest repin case in test_seed_repo_template.bats.
    • bats unavailable in this environment (not installed; run-bats.sh does not vendor it), so the .bats suites could not be executed here. This is a non-issue for this change: no shell script was modified and no bats test asserts on AGENTS.md content. The Python enforcing test and the required dev-lead-lint.sh both pass.
    • Out-of-scope observation (not changed): .github/workflows/auto-rebase.yml's header comment (line 10) still says auto-rebase/v2-stable while its uses: ref is @auto-rebase/v2-next — a separate intra-file comment drift the issue does not cover. Modifying the thin caller stub is outside this issue's scope; flagging it as a possible follow-up.
  4. added a commit that references this issue on Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugBug reportsdev-leadFor dev-lead agent pickupdocumentationDocumentation changesinitiativeEpic / initiative tracking issue

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions