Skip to content

Compliance: gitignore_baseline #1394

Closed

Description

@don-petry

Compliance Finding

Category: push-protection
Severity: error
Check: gitignore_baseline

Detail

.gitignore secrets-baseline block has drifted from the org canonical block (hash mismatch) — re-copy it verbatim; never edit inside the markers

Standard Reference

standards/gitignore-standard.md#l1--secrets-baseline-org-managed-verbatim-required

Remediation

Please review the linked standard and bring this repository into compliance.

See the full standards documentation for implementation guidance.


This issue was automatically created by the weekly compliance audit.

Activity

  1. don-petry commented on Jul 31, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead Implementation Plan

    Issue: #1394 — Compliance: gitignore_baseline

    Scope

    Re-copy the org-managed L1 secrets-baseline block in .gitignore verbatim from the canonical source (petry-projects/.github/.gitignore) to resolve the gitignore_baseline hash-mismatch drift finding.

    Root Cause

    The block between the # >>> BEGIN … >>> / # <<< END … <<< markers was edited in-place (which the standard forbids). Section 13 drifted:

    • Header text differs (…worktrees (org coding policy) vs canonical …worktrees and CI-generated tool artifacts (org coding policy)).
    • Repo has a stale .claude/scheduled_tasks.lock entry the canonical block no longer carries.
    • Repo is missing canonical entries: .dev-lead/, the actionlint comment, actionlint, actionlint.tar.gz.

    Implementation Checklist

    • Overwrite the L1 block (BEGIN…END, markers inclusive) in .gitignore with the canonical bytes; leave everything below the END marker (L2) untouched.
    • Verify the block is byte-identical to petry-projects/.github/.gitignore's L1 span.

    Tests to Write

    • None. Per the Phase 2 exception this is a pure-configuration, behavior-preserving change. The gitignore_baseline check is owned by the org compliance audit in petry-projects/.github (a network fetch); adding a local test that fetches the canonical block over the network would be non-hermetic/flaky, so no local test is added. Verification is a byte-for-byte diff against the canonical block.

    Verification / Lint Command

    bash .dev-lead/scripts/dev-lead-lint.sh and a byte diff of the L1 block against the canonical source.

  2. don-petry commented on Jul 31, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead: Implementation Complete

    Plan Execution

    • Overwrote the L1 secrets-baseline block (BEGIN…END, markers inclusive) in .gitignore with the canonical bytes from petry-projects/.github/.gitignore.
    • Left everything below the END marker (L2) untouched.
    • Verified the block is byte-identical to the canonical L1 span.

    Root Cause

    The block had been edited in-place (which the standard forbids). All drift was in section 13:

    • Header text was stale (…worktrees (org coding policy) → canonical …worktrees and CI-generated tool artifacts (org coding policy)).
    • Stale entry .claude/scheduled_tasks.lock removed (not tracked or present in this repo, so no behavioral impact).
    • Missing canonical entries restored: .dev-lead/, the actionlint comment, actionlint, actionlint.tar.gz.

    Verification

    Byte-for-byte match against the canonical block:

    repo L1 block  SHA-256: 61b7fb3be5d9725b4eca3381fa0e910504bb98900a1b9552c5ec749bde4f70f1
    canonical block SHA-256: 61b7fb3be5d9725b4eca3381fa0e910504bb98900a1b9552c5ec749bde4f70f1
    

    Required lint (bash .dev-lead/scripts/dev-lead-lint.sh): all checks passed (shellcheck on 98 files + 4 agent profiles + CODEOWNERS).

    Test suites (bats 1.13.0) — the push-protection and gitignore-touching generator suites:

    tests/test_push_protection.bats + tests/test_seed_repo_template.bats
    45 tests, 0 failures
    

    Files Changed

    • .gitignore: re-copied the org-managed L1 secrets-baseline block verbatim (section 13 realignment); L2 extensions below the END marker unchanged.

    Notes

    • Phase 2 (TDD) exception: pure-configuration, behavior-preserving change. The gitignore_baseline check is owned by the org compliance audit (pp_check_gitignore_baseline in petry-projects/.github) and validates over a network fetch of the canonical block; a local test replicating it would be non-hermetic/flaky, so no local test was added. Verification is the byte-for-byte SHA-256 match above.
    • .dev-lead/ (this agent's scratch worktree) is now correctly ignored per the canonical baseline.
  3. added a commit that references this issue on Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    compliance-auditAutomated compliance audit findingdev-leadFor dev-lead agent pickup

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions