You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The one failing run in the monitored window (run 30566787842) was a Dependabotpull_request
event. On Dependabot-authored PRs, GitHub withholds repository/org secrets, so the caller stub's secrets.GH_PAT_DON_PETRY || secrets.GH_PAT_WORKFLOWS resolves to an empty string. The reusable's
"Checkout ready-check tooling" step then receives an empty token and fails at startup with ##[error]Input required and not supplied: token — producing the 20% failure rate. All non-Dependabot
runs (workflow_run, check_suite, human pull_request) succeed because secrets are present.
Fix
Add a job-level if: github.actor != 'dependabot[bot]' guard to the caller job, mirroring the documented #864 precedent already in dev-lead-reusable.yml (a Dependabot pull_request run has no access to GH_PAT_WORKFLOWS, so the cross-repo checkout fails before it can classify/skip the event). Dependabot PRs
are handled by dependabot-automerge.yml and never need the review-agent dispatch, so skipping cleanly
before the reusable's checkout removes the false failure. This touches only the calling job's if: — the @pr-auto-review/v1-next channel, trigger event types, and permissions: block are left unchanged per the
stub's edit contract.
.github/workflows/test-dev-lead.yml — add a pr-auto-review-stub job that runs the new test, and add pr-auto-review.yml to the pull_request/push path filters
Tests to Write
tests/dev-lead/integration/test_pr_auto_review_stub.py — asserts the caller job that uses: the pr-auto-review reusable carries a Dependabot skip guard, and (regression) still pins the @pr-auto-review/v1-next channel
Test Command
python3 tests/dev-lead/integration/test_pr_auto_review_stub.py (full suite: the jobs in .github/workflows/test-dev-lead.yml)
The single failing run in the monitored window (30566787842) was a Dependabotpull_request
event. Dependabot runs receive no org/repo secrets, so the caller stub's secrets.GH_PAT_DON_PETRY || secrets.GH_PAT_WORKFLOWS resolved to an empty string and the reusable's
"Checkout ready-check tooling" step failed at startup with Input required and not supplied: token.
Every non-Dependabot run in the window succeeded — hence the 20% (1/5) rate.
Fix
Added a job-level if: github.actor != 'dependabot[bot]' guard to the pr-auto-review caller job,
mirroring the documented #864 precedent in dev-lead-reusable.yml. Dependabot PRs are handled by dependabot-automerge.yml and never need the review-agent dispatch, so the job now skips cleanly before
the reusable's checkout. The @pr-auto-review/v1-next channel, trigger event types, and permissions:
block are untouched, per the thin-caller edit contract.
Plan Execution
Added if: Dependabot guard to .github/workflows/pr-auto-review.yml
Added regression test tests/dev-lead/integration/test_pr_auto_review_stub.py
Registered pr-auto-review-stub job + path filters in .github/workflows/test-dev-lead.yml
TDD: confirmed test fails before the fix (red) and passes after (green)
Ran full stub suite + dev-lead-lint.sh + schedule/YAML validators — all pass
Test Results
=== TDD red phase (before fix) ===
FAIL: .github/workflows/pr-auto-review.yml caller stub is misconfigured:
Missing Dependabot guard: job 'if' is None
=== After fix — full integration stub suite ===
test_caller_permissions.py: PASS
test_workflow_toplevel_permissions.py: PASS
test_dependency_audit_stub.py: PASS
test_auto_rebase_stub.py: PASS
test_spec_drift_workflow.py: PASS
test_pr_auto_review_stub.py: PASS
=== Repo lint (.dev-lead/scripts/dev-lead-lint.sh) ===
[lint] shellcheck on 98 file(s)...
[lint] validating 4 agent profile(s)...
[lint] validating .github/CODEOWNERS...
[lint] all checks passed
=== Aux validators ===
YAML OK
schedule-lint: OK — no minute-0 (top-of-hour) scheduled crons found.
tests/test_sonar_s7637_exemption.sh: PASS
Files Changed
.github/workflows/pr-auto-review.yml: add if: github.actor != 'dependabot[bot]' guard (with rationale comment) to the caller job.
tests/dev-lead/integration/test_pr_auto_review_stub.py: new test asserting the caller job skips Dependabot and still pins @pr-auto-review/v1-next.
.github/workflows/test-dev-lead.yml: add pr-auto-review-stub test job and pr-auto-review.yml to the pull_request/push path filters.
Notes
The guard is intentionally a blanket github.actor check (matching dev-lead's bug(dev-lead): caller stub fires on Dependabot PRs and fails at startup (secrets unavailable) #864 guard): it also
skips workflow_run/check_suite events on Dependabot PRs, which is correct — those PRs are
auto-merged by dependabot-automerge.yml and never need a review-agent dispatch. Human-authored PRs
are unaffected.
The canonical long-term home for this behavior is the pr-auto-review-reusable.yml reusable in petry-projects/.github (per the stub header). This caller-level guard is the equivalent in-repo
remediation and can be removed if/when the reusable adopts the same skip.
Activity
don-petry commentedon Jul 31, 2026
Dev-Lead Implementation Plan
Issue: #1390 — [Fleet Monitor] petry-projects/.github-private — .github/workflows/pr-auto-review.yml
Root Cause
The one failing run in the monitored window (run
30566787842) was a Dependabotpull_requestevent. On Dependabot-authored PRs, GitHub withholds repository/org secrets, so the caller stub's
secrets.GH_PAT_DON_PETRY || secrets.GH_PAT_WORKFLOWSresolves to an empty string. The reusable's"Checkout ready-check tooling" step then receives an empty
tokenand fails at startup with##[error]Input required and not supplied: token— producing the 20% failure rate. All non-Dependabotruns (
workflow_run,check_suite, humanpull_request) succeed because secrets are present.Fix
Add a job-level
if: github.actor != 'dependabot[bot]'guard to the caller job, mirroring the documented#864precedent already indev-lead-reusable.yml(a Dependabotpull_requestrun has no access toGH_PAT_WORKFLOWS, so the cross-repo checkout fails before it can classify/skip the event). Dependabot PRsare handled by
dependabot-automerge.ymland never need the review-agent dispatch, so skipping cleanlybefore the reusable's checkout removes the false failure. This touches only the calling job's
if:— the@pr-auto-review/v1-nextchannel, trigger event types, andpermissions:block are left unchanged per thestub's edit contract.
Implementation Checklist
.github/workflows/pr-auto-review.yml— addif: github.actor != 'dependabot[bot]'to thepr-auto-reviewjob with an explanatory comment citing bug(dev-lead): caller stub fires on Dependabot PRs and fails at startup (secrets unavailable) #864.github/workflows/test-dev-lead.yml— add apr-auto-review-stubjob that runs the new test, and addpr-auto-review.ymlto thepull_request/pushpath filtersTests to Write
tests/dev-lead/integration/test_pr_auto_review_stub.py— asserts the caller job thatuses:the pr-auto-review reusable carries a Dependabot skip guard, and (regression) still pins the@pr-auto-review/v1-nextchannelTest Command
python3 tests/dev-lead/integration/test_pr_auto_review_stub.py(full suite: the jobs in.github/workflows/test-dev-lead.yml)don-petry commentedon Jul 31, 2026
Dev-Lead: Implementation Complete
Root Cause
The single failing run in the monitored window (
30566787842) was a Dependabotpull_requestevent. Dependabot runs receive no org/repo secrets, so the caller stub's
secrets.GH_PAT_DON_PETRY || secrets.GH_PAT_WORKFLOWSresolved to an empty string and the reusable's"Checkout ready-check tooling" step failed at startup with
Input required and not supplied: token.Every non-Dependabot run in the window succeeded — hence the 20% (1/5) rate.
Fix
Added a job-level
if: github.actor != 'dependabot[bot]'guard to thepr-auto-reviewcaller job,mirroring the documented
#864precedent indev-lead-reusable.yml. Dependabot PRs are handled bydependabot-automerge.ymland never need the review-agent dispatch, so the job now skips cleanly beforethe reusable's checkout. The
@pr-auto-review/v1-nextchannel, trigger event types, andpermissions:block are untouched, per the thin-caller edit contract.
Plan Execution
if:Dependabot guard to.github/workflows/pr-auto-review.ymltests/dev-lead/integration/test_pr_auto_review_stub.pypr-auto-review-stubjob + path filters in.github/workflows/test-dev-lead.ymldev-lead-lint.sh+ schedule/YAML validators — all passTest Results
Files Changed
.github/workflows/pr-auto-review.yml: addif: github.actor != 'dependabot[bot]'guard (with rationale comment) to the caller job.tests/dev-lead/integration/test_pr_auto_review_stub.py: new test asserting the caller job skips Dependabot and still pins@pr-auto-review/v1-next..github/workflows/test-dev-lead.yml: addpr-auto-review-stubtest job andpr-auto-review.ymlto thepull_request/pushpath filters.Notes
github.actorcheck (matching dev-lead's bug(dev-lead): caller stub fires on Dependabot PRs and fails at startup (secrets unavailable) #864 guard): it alsoskips
workflow_run/check_suiteevents on Dependabot PRs, which is correct — those PRs areauto-merged by
dependabot-automerge.ymland never need a review-agent dispatch. Human-authored PRsare unaffected.
pr-auto-review-reusable.ymlreusable inpetry-projects/.github(per the stub header). This caller-level guard is the equivalent in-reporemediation and can be removed if/when the reusable adopts the same skip.
feat: implement issue #1390 — [Fleet Monitor] petry-projects/.github-…