Skip to content

Compliance: gitignore_baseline #1371

Closed

Description

@don-petry

Compliance Finding

Category: push-protection
Severity: error
Check: gitignore_baseline

Detail

.gitignore is missing the BEGIN … END petry-projects secrets baseline block — copy it verbatim from the org /.gitignore

Standard Reference

standards/gitignore-standard.md#managed-block-markers

Remediation

Please review the linked standard and bring this repository into compliance.

See the full standards documentation for implementation guidance.


This issue was automatically created by the weekly compliance audit.

Activity

  1. don-petry commented on Jul 24, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead Implementation Plan

    Issue: #1371 — Compliance: gitignore_baseline

    Scope

    Wrap the existing org secrets-baseline block in .gitignore with the required BEGIN … END petry-projects secrets baseline managed-block markers per standards/gitignore-standard.md#managed-block-markers.

    Diagnosis

    The repo .gitignore already contains the full org secrets-baseline content (the 13-section SECRETS ONLY block), but it is missing the two managed-block delimiter lines the compliance audit hashes against:

    • BEGIN: # >>> BEGIN petry-projects secrets baseline (managed by .github — do not edit) >>>
    • END: # <<< END petry-projects secrets baseline <<<
      Per the standard, everything between the markers is the L1 (org-managed) block; everything below END is L2 (per-repo, freely edited). The repo's L2 content (Python bytecode, .claude/skills/, /gitleaks) stays below the END marker untouched.

    Implementation Checklist

    • Insert BEGIN marker as the first line of .gitignore, immediately above the # === baseline header
    • Insert END marker immediately after the closing # End of petry-projects secrets baseline # === block, above the per-repo L2 section
    • Leave the L1 block content byte-for-byte unchanged; leave L2 content unchanged

    Tests to Write

    • Phase 2 (TDD) exception: this is a behavior-preserving configuration change (adding two delimiter comment lines to .gitignore). No repo-local validator/test exists for the gitignore marker block (the audit runs in petry-projects/.github). Exception noted per the prompt's Phase 2 guidance; verification is via lint + full suite in Phase 4.

    Test Command

    bash .dev-lead/scripts/dev-lead-lint.sh plus the repo bats suite

  2. don-petry commented on Jul 24, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead: Implementation Complete

    Plan Execution

    • Diagnosed: .gitignore already carried the full org secrets-baseline content but was missing the two managed-block delimiter lines the compliance audit keys on
    • Inserted BEGIN marker as the first line, immediately above the # === baseline header
    • Inserted END marker immediately after the closing # End of petry-projects secrets baseline block, above the per-repo L2 section
    • Left the L1 block content byte-for-byte unchanged and the L2 content (__pycache__/, .claude/skills/, /gitleaks) untouched below the END marker

    Test Results

    Phase 2 (TDD) exception applied: this is a behavior-preserving configuration change (adding two delimiter comment lines to .gitignore). No repo-local validator exists for the marker block — the gitignore_baseline audit runs in petry-projects/.github. Verification was done via the required repo lint plus a diff review.

    Required repo lint (bash .dev-lead/scripts/dev-lead-lint.sh):

      [lint] shellcheck on 98 file(s)...
      [lint] validating 4 agent profile(s)...
    OK: agents/agentic-workflows.md
    OK: agents/compliance-auditor.md
    OK: agents/feature-ideator.md
    OK: agents/pr-reviewer.md
      [lint] validating .github/CODEOWNERS...
    OK: .github/CODEOWNERS
      [lint] all checks passed
    

    Note: bats is not installed in this environment, so the broader bats suite could not be executed here. The change touches only .gitignore (two comment lines); no bats test asserts against the secrets-baseline content, so there is no code path affected by this change.

    Files Changed

    • .gitignore: added the managed-block markers around the existing L1 org secrets baseline —
      • top: # >>> BEGIN petry-projects secrets baseline (managed by .github — do not edit) >>>
      • after the closing block: # <<< END petry-projects secrets baseline <<<

    Diff:

    @@ -1,3 +1,4 @@
    +# >>> BEGIN petry-projects secrets baseline (managed by .github — do not edit) >>>
     # ============================================================================
     # petry-projects baseline .gitignore — SECRETS ONLY
     # ----------------------------------------------------------------------------
    @@ -390,6 +391,7 @@ private.yml
     # ============================================================================
     # End of petry-projects secrets baseline
     # ============================================================================
    +# <<< END petry-projects secrets baseline <<<
     
     # Python bytecode
     __pycache__/

    Notes

    Per standards/gitignore-standard.md#managed-block-markers, everything between the markers is the L1 (org-managed) block and everything below the END marker is L2 (per-repo, freely edited). The repo's existing per-repo entries were already positioned after the baseline, so they now correctly sit below the END marker with no reordering required. No follow-up issues.

  3. added a commit that references this issue on Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    compliance-auditAutomated compliance audit findingdev-leadFor dev-lead agent pickup

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions