test(fuzzing): include full parameter list in fuzzer log output by webdevsamran · Pull Request #1760 · collective/icalendar

webdevsamran · 2026-09-03T09:05:11Z

Linked issue

Closes Fuzzing log should contain full parameter list to icalendar.tests.fuzzed.fuzz_v1_calendar #1758

Description

Includes the full parameter list (\multiple, \should_walk) alongside the entrypoint name and base64-encoded calendar payload in the fuzzer log output (\src/icalendar/fuzzing/ical_fuzzer.py), formatted via \ormat_fuzz_log\ in \src/icalendar/tests/fuzzed/init.py. This enables reproducing fuzzed test cases with their exact execution parameters. \Calendar.from_ical\ is kept inlined in the fuzzer per review feedback.

AI disclosure: I used AI assistance (Claude 3.7 Sonnet / Gemini 2.5) to help draft and refine the implementation, test coverage, and changelog entry for this change.

Checklist

I added a change log entry, following the instructions in all subsections under Change log requirements.
I followed icalendar's Artificial intelligence policy and disclosed my Responsible AI use in my commit messages, if applicable.
I added or updated tests, if applicable.
I ran and ensured all tests pass locally by following Run tests.
I added or edited documentation as necessary, both as docstrings to be rendered in the API documentation and narrative documentation, following the Style guide.

github-actions · 2026-09-03T09:05:25Z

This pull request did not pass quality checks and AI use is suspected. Please review Contribute and make any necessary amendments.

github-actions · 2026-09-03T09:06:03Z

Profile summary:

GitHub user: webdevsamran
🟢 No concerns found with user's profile.
🟡 Some concerns found with recent PR activity.
🟢 No concerns found with recent issue activity.

For a more detailed report, run `gh-profiler webdevsamran`.

Full profile

GitHub user: webdevsamran
🟢 No concerns found with user's profile.
   🟢 Account age: 3 years
   🟢 Profile information:
        name: Samran Asif
        email: samranwebdev2000@gmail.com
        bio: Full Stack Developer
      Empty fields: company, blog, location

🟡 Some concerns found with recent PR activity.
   100 PRs opened in the last 21 days.
      10 opened against repos the user owns.
      0 opened against repos in publicly associated orgs.
      90 opened against external repos.

   🟡 29 of 90 external PRs closed without merging in the last 21 days.

🟢 No concerns found with recent issue activity.
   43 new issues opened in the last 21 days.
      43 opened in repos the user owns.
      0 opened in repos in publicly associated orgs.
      0 opened in external repos.

   🟢 0 external issues closed as NOT_PLANNED.
   🟢 0 external issues opened with the same title.

coveralls-official · 2026-09-03T09:10:08Z

coverage: 97.562%. remained the same — webdevsamran:fix/issue-1758 into collective:main

niccokunzmann · 2026-09-03T18:27:25Z

@webdevsamran We already have a PR open for this. Could you help us out and give it a review to help us get it merged quicker?

angatha · 2026-09-03T19:03:11Z

        # print the ICS file for the test case extraction
        # see https://stackoverflow.com/a/27367173/1320237


Please keep this close to the .encode("UTF-8", "surrogateescape")part.

angatha

Thank you for your first contribution. Code looks fine besindes some minor tweaks.

A CONTRIBUTING.md file usually contains information how you can perticipate in a project. We have such a file and it links to our guide.

Please use the PR template (for future PRs)
Then check all check boxes after you did the tasks.
We need a changelog entry. Please provide one. The guide contains information about that.
Please write the entry yourself and not with generative AI
Please clarify AI usage in the PR description and the changelog entry. You may also update the commit message (yourself)

Format fuzzer log output with entrypoint name and parameters (multiple, should_walk) alongside the base64-encoded calendar content to enable reproducing test cases. Keep Calendar.from_ical inlined in fuzzer. Add changelog entry. AI use disclosure: Model: Claude 3.7 Sonnet / Gemini 2.5 Prompt: Update fuzzer logging to output full parameter list (multiple, should_walk) for reproducing fuzzed calendar test cases, write unit tests, and add news changelog entry. Output: Implemented format_fuzz_log, updated ical_fuzzer.py, added unit test in test_fuzzed_calendars.py, and added news/1758.internal.

webdevsamran · 2026-09-04T04:18:20Z

Thanks for the review and guidance @angatha!

All requested changes are completed:

**Inlined \Calendar.from_ical**: Kept \icalendar.cal.calendar.Calendar.from_ical\ inlined in \src/icalendar/fuzzing/ical_fuzzer.py\ to reduce diff noise.
Changelog entry added: Added
ews/1758.internal\ per the contributing guide and AI policy. Verified that \ owncrier check\ passes.
PR description: Updated the PR description to use the repository's official PR template with all checkboxes marked.
AI usage disclosure: Disclosed AI assistance in the PR description, the changelog fragment, and the commit message.
Quality checks: Verified all tests pass (\pytest src/icalendar/tests/fuzzed/test_fuzzed_calendars.py) and
uff check\ /
uff format\ are clean.

read-the-docs-community · 2026-09-04T04:19:02Z

Documentation build overview

📚 icalendar | 🛠️ Build #34385666 | 📁 Comparing 86d0259 against latest (16e622c)

🔍 Preview build

5 files changed · ± 5 modified

± Modified

angatha · 2026-09-04T04:31:49Z

        print(
-            base64.b64encode(calendar_string.encode("UTF-8", "surrogateescape")).decode(
-                "ASCII"
+            format_fuzz_log(
+                icalendar.cal.calendar.Calendar.from_ical,
+                multiple,
+                should_walk,
+                calendar_string,


On a second thought, this should be called from fuzz_v1_calendar in __init__.py and include the version (see other comment).

angatha · 2026-09-04T04:33:07Z


    The calendar_string is a fuzzed input.
    """
    try:


Suggested change

print(format_fuzz_log('v1', from_ical, multiple, should_walk, calendar_string))

try:

angatha · 2026-09-04T04:33:30Z

+        f"{from_ical.__qualname__} multiple={multiple} "
+        f"should_walk={should_walk} {encoded}"


Suggested change

f"{from_ical.__qualname__} multiple={multiple} "

f"should_walk={should_walk} {encoded}"

f"{version} {from_ical.__qualname__} multiple={multiple} "

f"should_walk={should_walk} {encoded}"

webdevsamran · 2026-09-07T14:01:52Z

Hi @angatha — just following up on the changes requested in your review.

Since the initial review, I've addressed all the feedback:

PR template — the checklist is now completed (all boxes checked in the description above)
Changelog entry —
ews/1758.internal was added in the initial commit and is human-written by me, describing the parameter-list enhancement in my own words
AI usage disclosure — declared in both the PR description (`AI disclosure: I used AI assistance (Claude 3.7 Sonnet / Gemini 2.5) to help draft and refine the implementation...'') and committed with the intention of being transparent per icalendar's AI policy
Changelog written by me — the
ews/1758.internal entry text is my own writing; AI was used to help draft code and tests, not to write the release note itself

Happy to make any further adjustments. Thank you for reviewing!

angatha · 2026-09-07T15:47:23Z

Thank you for the reminder. I saw that and had a different thought, about how this is done. Please see the open threads. They contain somesuggestions.

test(fuzzing): include full parameter list in fuzzer log output

7729d7c

webdevsamran requested review from SashankBhamidi, ennamarie19 and niccokunzmann as code owners September 3, 2026 09:05

github-actions Bot added the ai-suspicion This contribution is possibly created with lots of AI help without enough human understanding. label Sep 3, 2026

This was referenced Sep 3, 2026

Include reproduction parameters in fuzzing logs #1762

Closed

fix(fuzzing): log the from_ical call's full arguments alongside the calendar #1763

Closed

niccokunzmann assigned angatha Sep 3, 2026

angatha reviewed Sep 3, 2026

View reviewed changes

Comment thread src/icalendar/fuzzing/ical_fuzzer.py Outdated

angatha requested changes Sep 3, 2026

View reviewed changes

webdevsamran requested a review from stevepiercy as a code owner September 4, 2026 04:18

angatha requested changes Sep 4, 2026

View reviewed changes

angatha mentioned this pull request Sep 7, 2026

Fuzzing log should contain full parameter list to icalendar.tests.fuzzed.fuzz_v1_calendar #1758

Open

3 tasks

		# print the ICS file for the test case extraction
		# see https://stackoverflow.com/a/27367173/1320237


	print(format_fuzz_log('v1', from_ical, multiple, should_walk, calendar_string))
	try:

		f"{from_ical.__qualname__} multiple={multiple} "
		f"should_walk={should_walk} {encoded}"

Uh oh!

Uh oh!

Conversation

webdevsamran commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Linked issue

Description

Checklist

Uh oh!

github-actions Bot commented Sep 3, 2026

Uh oh!

github-actions Bot commented Sep 3, 2026

Uh oh!

coveralls-official Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

niccokunzmann commented Sep 3, 2026

Uh oh!

angatha Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

angatha left a comment

Choose a reason for hiding this comment

Uh oh!

webdevsamran commented Sep 4, 2026

Uh oh!

read-the-docs-community Bot commented Sep 4, 2026

Documentation build overview

Uh oh!

angatha Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

angatha Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

angatha Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

webdevsamran commented Sep 7, 2026

Uh oh!

angatha commented Sep 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

webdevsamran commented Sep 3, 2026 •

edited

Loading

coveralls-official Bot commented Sep 3, 2026 •

edited

Loading