feat(cds-android): port Button to Compose and add RN-to-Compose skill - #877
Open
cb-ekuersch wants to merge 7 commits into
Open
cb-ekuersch wants to merge 7 commits into
cb-ekuersch wants to merge 7 commits into
Conversation
Collaborator
🟡 Heimdall Review Status
🟡
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
🟡
0/1
|
Denominator calculation
|
github-actions
Bot
added
root
packages:cds-android
apps:android-app
docs
apps:ios-gallery
labels
cb-ekuersch
marked this pull request as ready for review
September 10, 2026 16:39
6 tasks
Dustin4444
reviewed
Sep 23, 2026
Dustin4444
left a comment
Dustin4444
left a comment
There was a problem hiding this comment.
🟡 Heimdall Review Status
Requirement Status More Info Reviews 🟡 0/1Denominator calculation
Show calculation
1if user is bot0 1if user is external0 2if repo is sensitive0 From .codeflow.yml1 Additional review requirements Show calculation
Max 0 0 From CODEOWNERS1 Global minimum 0 Max 1 1 1if commit is unverified0 Sum 1 CODEOWNERS🟡 See below 🟡
CODEOWNERS
Code Owner Status Calculation ui-systems-eng-team 🟡 0/1Denominator calculation
Additional CODEOWNERS Requirement Show calculation
Sum 0 0 From CODEOWNERS1 Sum 1
Ship public Button and shared interaction primitives with Robolectric tests, gallery coverage, and docs. Add cds-rn-to-compose skill to guide future mobile-to-Android ports and audits. Co-authored-by: Cursor <cursoragent@cursor.com>
Route unmatched documentation to a Format Docs job so Android-only PRs are not blocked by Node format and bundle-stats. Co-authored-by: Cursor <cursoragent@cursor.com>
Run tools:format from root CI on JS/TS/JSON/Markdown so docs and skills are checked without starting Node CI, and drop format from the Node workflow. Co-authored-by: Cursor <cursoragent@cursor.com>
Move component demos off monolithic home scrolls to prepare for visreg and Maestro flows, and extend the RN-to-Compose skill with testTag guidance. Co-authored-by: Cursor <cursoragent@cursor.com>
Restore nx format:check in the Node workflow while keeping docs/skills off the Node CI classifier, and remove per-component cds-android docs. Co-authored-by: Cursor <cursoragent@cursor.com>
cb-ekuersch
force-pushed
the
cursor/android-button-port-rn-to-compose-skill
branch
from
September 23, 2026 22:10
b6487b5 to
d653f64
Compare
Drop the branch-only tweak that let format run on docs/skills-only PRs; keep node.yml and the CI docs identical to master's language-arm behavior instead of carrying an arbitrary local divergence. Co-Authored-By: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Ports the CDS mobile Button to a public Jetpack Compose implementation in
packages/cds-android, including shared interaction affordances (CdsInteractionDefaults), Robolectric behavior tests, demo gallery coverage, and package docs.Also adds the
cds-rn-to-composeagent skill to guide future React Native → Compose ports and audits, with discovery/audit checklists, CompositionLocal theming guidance, and a living learnings log.Root cause (required for bugfixes)
N/A — feature work.
UI changes
Buttonwith variants, states, icon slots, and gallery sectionTesting
How has it been tested?
Testing instructions
With an emulator or device connected:
Verify Button variants, transparent mode, disabled/loading states, icon slots, and full-width layout in the demo app gallery.
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**N/A
Change management
type=routine
risk=low
impact=sev5
automerge=false
Made with Cursor