Skip to content

fix(mobile): hide non-positive DotCount values - #793

Open
tallyhuhu wants to merge 1 commit into
coinbase:masterfrom
tallyhuhu:fix/mobile-dotcount-negative-values
Open

tallyhuhu wants to merge 1 commit into
coinbase:masterfrom
tallyhuhu:fix/mobile-dotcount-negative-values

Conversation

@tallyhuhu

Copy link
Copy Markdown

Summary

DotCount documents that it should be hidden when count <= 0, but the mobile implementation only handled zero and could display negative values. This change aligns mobile behavior with the existing web implementation by hiding all non-positive counts while preserving enter and exit animations.

Added regression coverage for negative counts.

Testing

  • yarn nx run mobile:test --testMatch='**/*.test.tsx' --testPathPattern=DotCount.test.tsx
  • yarn nx run mobile:typecheck
  • yarn nx format:write

@cb-heimdall

Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
CODEOWNERS 🟡 See below

🟡 CODEOWNERS

Code Owner Status Calculation
ui-systems-eng-team 🟡 0/1
Denominator calculation
Additional CODEOWNERS Requirement
Show calculation
Sum 0
0
From CODEOWNERS 1
Sum 1

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants