Skip to content

Reconsider "lets" being a common misspelling of "let's" #3629

Description

@Piedone

"Let's" is a contraction of "let us", while "lets" is the third-person singular form of the verb "let". In #3468 the lets->let's mapping was added. While people indeed frequently misspell "let's" as "lets", I'd argue that the correct use of "lets" may be frequent enough that such a mapping does more harm than good.

I've updated codespell to 2.4.1 in our Lombiq's Open-Source Orchard Core Extensions project, including that it also runs for its submodules. While this might not be representative, it contains about 51k LOC in C#, and I'd guess at least a further 10k in CSS, JS, MD, YML, PS1, and other files.

After the update, I've got 17 errors for "lets", with a single one being an actual misspelling, 16 being false positives. So, it seems to me that this mapping is not useful. Thus, I'd ask you to please reconsider it, and I suggest removing it.

Activity

  1. DimitriPapadopoulos commented on Feb 3, 2025

    @DimitriPapadopoulos
    Collaborator

    Ooops... Sorry for letting this through. Would you agree to create a PR to revert?

  2. Piedone commented on Feb 3, 2025

    @Piedone
    ContributorAuthor

    Oh sure: #3633. Thank you for your quick reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dictionaryChanges to the dictionary

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions