Skip to content

ci: trim wasted runs and name jobs after what they check - #1243

Open
matifali wants to merge 2 commits into
mainfrom
atif/ci-workflow-efficiency
Open

matifali wants to merge 2 commits into
mainfrom
atif/ci-workflow-efficiency

Conversation

@matifali

@matifali matifali commented Nov 9, 2026

Copy link
Copy Markdown
Member

Description

Small efficiency and clarity fixes outside ci.yaml:

  • golangci-lint: runs only when *.go, go.mod/go.sum, .golangci.yml, or the workflow change. Today it runs on every PR, including template and README PRs. Superseded PR runs are now cancelled, and the unused master trigger is gone. This check is not required by the ruleset, so the path filter can't block merges.
  • zizmor: cancels superseded PR runs.
  • check-registry-site-health (every 15 min): adds a 10-minute timeout and a concurrency group, so a hung run can't burn 6 hours or overlap the next run.
  • version-bump: removes the unused Terraform setup; the script only shells out to bun/prettier.
  • Job names: lint → Lint Go code, the zizmor jobs → Audit workflows (high severity / upload SARIF), run-script → Check registry.coder.com health, version bump → Check module version bump. None of these are required checks.

Type of Change

  • Other (CI)

Testing & Validation

  • actionlint: no new findings (all 19 are pre-existing in release.yml/version-bump.yaml)
  • zizmor: medium findings drop from 13 to 10
  • prettier clean

Related Issues

Part 3 of 3 CI PRs; independent of the other two.

🤖 Generated with Claude Code

matifali and others added 2 commits November 9, 2026 15:35
- golangci-lint: run only when Go files, go.mod/go.sum, or the lint
  config change, cancel superseded PR runs, and drop the unused
  `master` branch trigger.
- zizmor: cancel superseded PR runs.
- check-registry-site-health: add a timeout and a concurrency group so a
  hung run cannot overlap the next 15-minute run.
- version-bump: drop the unused Terraform setup; the script only needs
  bun for prettier.
- Give jobs descriptive names ("Lint Go code", "Audit workflows (...)",
  "Check registry.coder.com health", "Check module version bump"), and add
  timeouts and persist-credentials: false where missing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@matifali
matifali force-pushed the atif/ci-workflow-efficiency branch from 3676b30 to 9712815 Compare November 9, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant