AbstractArchiver.getFiles returns platform-specific separators (for ZIP files) #129

Activity

1. kwin commented on Nov 16, 2019

   

   kwin

   on Nov 16, 2019

   Last edited by kwin

   Author

   More actions

   For the actual ZIP generation the normalization is done by

   plexus-archiver/src/main/java/org/codehaus/plexus/archiver/zip/AbstractZipArchiver.java

   Line 370 in b9ea3bf

   name = name.replace( File.separatorChar, '/' );

   . This is not called for getFiles() though.
2. kwin commented on Nov 16, 2019

   

   kwin

   on Nov 16, 2019

   Author

   More actions

   Ok, the issue was that the check was performed on AbstractArchiver.getFiles() where the file name normalization has not happened yet. I wonder whether that is expected behaviour though. IMHO AbstractArchiver.getFiles() should already return the normalized names as keys.
3. plamentotev commented on Nov 21, 2019

   

   plamentotev

   on Nov 21, 2019

   Last edited by plamentotev

   More actions

   Hi,

   Sorry but I'm not quite sure if there is a bug in Plexus Archiver or you made it work? If you believe there is a bug would you please share a code snipped that reproduces the issue? I ran one of the tests on Windows and it looks like the resulting ZIP archive is with / as file path separator.

   As for AbstractArchiver.getFiles() - it is common for all acrhivers so it also makes sense not to normalized the names and let the concrete implementation decide if such normalization is needed. Although I not quite sure if there is any benefit from storing the Windows separator in the archived file name even if the archive format supports it.
4. kwin commented on Nov 23, 2019

   

   kwin

   on Nov 23, 2019

   Last edited by kwin

   Author

   More actions

   @plamentotev Indeed the generated ZIP file is correct (i.e. only contains forward slashes). It is just AbstractArchiver.getFiles() which behaves unexpectedly. I would expect the entry names as they appear in the Zip. If in case of all other archivers there is no normalization necessary you would probably need to overwrite that method only for ZipArchiver. In any case it would be very helpful if the javadoc for getFiles would be extended with regards to the file name format which could be expected here.
5. kwin

   changed the title [-]AbstractArchiver.addFileSet adds platform-specific separators[/-] [+]AbstractArchiver.getFiles returns platform-specific separators (for ZIP files)[/+] on Nov 23, 2019
6. plamentotev commented on Dec 27, 2019

   

   plamentotev

   on Dec 27, 2019

   More actions

   Yes, good point. Actually getFiles does not have any documentation at all. I might give it a try when I have more time. Contributions are welcome as well :)
7. slachiewicz

   assigned

   Copilot

   on Oct 5, 2025
8. slachiewicz

   closed this as completedin #392on Oct 8, 2025