[pull] master from mozilla:master - #493
Merged
Merged
Conversation
When a non-embedded CID font lacks both a glyph map and a ToUnicode entry, its CIDs are glyph IDs and PDF.js must infer an ordering. The standard-font map does not match Trebuchet MS or Windows Symbol. Build the Trebuchet MS mapping from MacStandardGlyphOrdering plus supplemental entries, and map Windows Symbol glyph IDs by character code. Also map Adobe arrow and integral extenders from private-use code points to Unicode. It fixes #21713.
Preserve the pinch state across tracked-pair changes so scaling resumes without crossing the dead zone again. Reset it once fewer than two tracked touches remain. Also re-arm the pointerdown guard when one touch remains, preventing a returning finger from starting an editor drag.
It fixes #21667.
The `RefSet` and `RefSetCache` classes are old enough that they predate a lot of modern JavaScript features, e.g. originally they stored their data in regular Objects. About six years ago, see PRs 11977 and 12089, these classes were converted to use a Set respectively a Map internally. Given that `RefSet` is a wrapper around a standard Set, it seems reasonable to re-name `RefSetCache` to `RefMap` when it's a wrapper around a standard Map.
This allows the viewer to check for enabled/disabled permissions using `Set.prototype.has()`, which is generally more efficient than `Array.prototype.includes()`. *Note:* Permissions are not enabled by default in the viewer.
[api-minor] Convert `getPermissions` to return data in a Set
Improve glyph mapping for non-embedded CID fonts
Re-name the `RefSetCache` class to `RefMap`
Expose more tagged PDF structure roles
Hide unavailable alt text settings
Keep pinching when the touch set changes
… ones in the unit-tests Generally speaking it seems like a good idea to have the unit-tests be *explicit* about their expected values, rather than accepting "arbitrary" truthy/falsy values.
Also, add a unit-test for the `parent` argument since that was currently missing.
…uthy-toBeFalsy Replace most `toBeTruthy()`/`toBeFalsy()` matchers with more specific ones in the unit-tests
Change `RefSet` and `RefMap` to use actually private class fields
…iveness Improve ink drawing responsiveness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )