[pull] master from mozilla:master - #485
Merged
Merged
Conversation
The local part and the domain labels were unbounded, making the search quadratic in the length of a run of characters preceding an "@": scanning the text of a single page could take seconds.
`toFixed(10)` switches to the exponential notation from 1e21 on, which isn't valid PDF syntax, and removing the trailing zeros then dropped a digit of the exponent: 1e30 was written "1e+3" and 1e100 "1e+1". Such a number, necessarily an integer, is now written with all its digits. The trailing zeros are removed with a backward scan, since `toFixed(10)` always produces exactly 10 decimals. Below the 1e21 limit its output is at most 33 characters long, so the previous `$`-anchored regex wasn't a performance issue.
Matching the name with a leading `.+` is quadratic in the length of a component which doesn't end with a position, and every AcroForm field name goes through this.
Anchor the regex used to extract the XFA path positions
Don't write numbers in exponential notation when saving a pdf
Bound the email parts in the autolinker regex
Safely serialize CSS font family names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )