[pull] master from mattermost:master - #896
Merged
Merged
Conversation
* Add Playwright E2E tests for demo plugin webapp components Adds 7 new spec files covering the demo plugin's webapp components: Root Modal (user actions, menus, post dropdown), sidebar components, channel header button/RHS, file upload/preview components, and user settings. Updates helpers.ts with shared assertRootModal and closeRootModal helpers. Adds sample-file.demo test asset. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> * Address CodeRabbit review feedback - Scope 'more actions' button to post container in demo_file_components - Replace regex with string for profile popover accessible name - Replace evaluate click with .click() and clean up dialog handler in demo_user_settings - Remove Cancel bug test from demo_root_modal_menus with explanatory comment Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> * Implement feedback as per review Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> * Implement CodeRabbit suggestion: wait for upload response in uploadFileViaYourComputer Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> * Implement CodeRabbit suggestion: scope hover to post container in demo_file_components Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> * fix: use import type for Client4 to satisfy consistent-type-imports rule Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * E2E/Test: Skip broken Sample Confirmation Dialog test; fix default_config after master merge - Skip demo_root_modal_menus "Sample Confirmation Dialog": unable to resolve this test failure, it is a bug with the demo plugin. v0.10.3 does not set a URL on the openInteractiveDialog call, causing the webapp to log "Interactive dialog missing URL" and render nothing. Test will be re-enabled once the plugin is fixed and the build bumped. - Remove EnableAccessControlAuditLogging and AIRecapSettings from default_config.ts — both fields were removed when I synced up from master. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * E2E/Test: Restore EnableAccessControlAuditLogging and AIRecapSettings to default_config Both fields are still required in @mattermost/types as of master. They were incorrectly removed in the previous commit because the local dist was stale after the master merge. Rebuilt webapp platform packages to confirm correct type state before restoring. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )