Skip to content

Add retry logic for helm install hook failures in release deploy #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ricardobernardino2024 merged 1 commit into from
Sep 1, 2026
Merged

Add retry logic for helm install hook failures in release deploy #838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .do/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,9 @@ clean_jobs:
-kubectl delete jobs -l app.kubernetes.io/instance=${RELEASE_NAME} --namespace ${NAMESPACE} --ignore-not-found=true

.PHONY: deploy_to_doks_from_chartmuseum
deploy_to_doks_from_chartmuseum: set_cluster_context setup_helm_repos clean_jobs helm_install_from_chart_museum
deploy_to_doks_from_chartmuseum: set_cluster_context setup_helm_repos
-$(MAKE) clean_jobs

@codacy-production codacy-production Bot Aug 31, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ LOW RISK

Nitpick: The hyphen prefix is redundant as the 'clean_jobs' target already handles potential errors internally.\n\nsuggestion\n\t$(MAKE) clean_jobs\n

$(MAKE) helm_install_from_chart_museum || ($(MAKE) clean_jobs && $(MAKE) helm_install_from_chart_museum)

@codacy-production codacy-production Bot Aug 31, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ LOW RISK

Suggestion: Add a log message to signal the retry. This improves observability in CI logs when the initial install fails due to hook jobs.\n\nsuggestion\n\t$(MAKE) helm_install_from_chart_museum || (echo "Helm install failed, retrying after cleaning jobs..." && $(MAKE) clean_jobs && $(MAKE) helm_install_from_chart_museum)\n


.PHONY: set_cluster_context
set_cluster_context:
Expand Down