Refactor to support strong typing. - #42
Merged
Merged
Conversation
Contributor
Author
|
Seems like |
nreynis
force-pushed
the
feature/strong-typing
branch
from
September 14, 2019 20:29
3f5fd00 to
f50fbdc
Compare
Contributor
Author
|
Fixed tests and squashed commits |
nreynis
force-pushed
the
feature/strong-typing
branch
from
September 14, 2019 20:40
f50fbdc to
cc51fdd
Compare
More reliable pattern for TypeError detection
nreynis
force-pushed
the
feature/strong-typing
branch
from
September 14, 2019 20:46
cc51fdd to
0ab5c8c
Compare
florianeckerstorfer
approved these changes
Sep 15, 2019
Member
|
Awesome, thank you so much for the work |
Contributor
Author
|
You're welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added strong typing everywhere it was possible.
I also:
@coversannotations but reverted it because the FQCN is requiredAdding strong typing made me spot two bugs that I fixed in the meantime:
sortKeysWithDefaultSortingAndReverseOptionhad a bug, you were passing null assuming it would take the default value. This is not how PHP handles that, default values are provided only if you pass nothing at all. Passing an explicitnullwill give you anull(now aTypeErroras the param isn't nullable). As you were passing the second argument you've got no choice: you're forced to pass the first.