bump app version [skip ci] - #1210
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed version update has no unresolved issues.
Pull request overview
Updates the Cortex library Helm chart to reference a new application image version.
Changes:
- Bumps
appVersionfromsha-83e5f5ectosha-896a5fca.
File summaries
| File | Description |
|---|---|
helm/library/cortex/Chart.yaml |
Updates the Cortex application version. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
63c38b6 to
20d7985
Compare
20d7985 to
357b3a4
Compare
357b3a4 to
03f2084
Compare
03f2084 to
2ead6db
Compare
2ead6db to
b15a816
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The modified Helm Chart.yaml files are missing the repo-standard copyright/SPDX header used by other charts, which should be added for consistency/compliance.
Review details
Suppressed comments (2)
helm/library/cortex-shim/Chart.yaml:6
- This Chart.yaml is missing the standard copyright/SPDX header that other charts in this repo include (e.g., helm/library/cortex-postgres/Chart.yaml:1-2, helm/dev/cortex-prometheus-operator/Chart.yaml:1-2). Adding it improves license compliance consistency across Helm charts.
type: application
version: 0.1.18
appVersion: "sha-b4392f54"
helm/library/cortex/Chart.yaml:6
- This Chart.yaml is missing the standard copyright/SPDX header that other charts in this repo include (e.g., helm/library/cortex-postgres/Chart.yaml:1-2, helm/dev/cortex-prometheus-operator/Chart.yaml:1-2). Adding it improves license compliance consistency across Helm charts.
type: application
version: 0.4.3
appVersion: "sha-b4392f54"
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
6c856d6 to
21507db
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The charts’ appVersion was updated without a corresponding chart version/dependency update path, which can prevent consumers pinned to the current chart versions from reliably receiving the new app SHA.
Get a fresh assessment by requesting another Copilot review.
Review details
Suppressed comments (2)
helm/library/cortex/Chart.yaml:6
- This chart file is missing the standard license header comment used by the other Helm charts (e.g. helm/bundles/cortex-nova/Chart.yaml:1-2).
appVersion: "sha-b4392f54"
helm/library/cortex-shim/Chart.yaml:6
- This chart file is missing the standard license header comment used by the other Helm charts (e.g. helm/bundles/cortex-nova/Chart.yaml:1-2).
appVersion: "sha-b4392f54"
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
21507db to
8ffd577
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The modified Chart.yaml files are missing the project’s required Apache-2.0 license header comment, which should be added for consistency/compliance.
Review details
Suppressed comments (2)
helm/library/cortex/Chart.yaml:6
- This Chart.yaml is missing the required Apache-2.0 license header comment used elsewhere in the repo (e.g., helm/library/cortex-postgres/Chart.yaml:1-2). Add the header at the top of the file for consistency and compliance.
appVersion: "sha-dc3d8881"
helm/library/cortex-shim/Chart.yaml:6
- This Chart.yaml is missing the required Apache-2.0 license header comment used elsewhere in the repo (e.g., helm/library/cortex-postgres/Chart.yaml:1-2 and helm/library/cortex-shim/templates/ingress.yaml:1-2). Add the header at the top of the file for consistency and compliance.
appVersion: "sha-10eb153c"
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
8ffd577 to
99ff8cb
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
appVersion was changed without bumping the Helm chart version, which can prevent downstream consumers (bundles pinning chart versions) from receiving this update via the OCI chart repository.
Review details
Suppressed comments (2)
helm/library/cortex/Chart.yaml:6
- Changing appVersion without bumping the chart
versionmakes it hard/impossible for consumers pulling from the OCI Helm repo to pick up the new image tag (bundles pincortexatversion: 0.4.3, e.g.helm/bundles/cortex-nova/Chart.yaml:17-25). Consider bumping the chart version (and updating dependent bundle chart dependency versions) so a new chart artifact can be published and consumed normally.
version: 0.4.3
appVersion: "sha-10eb153c"
helm/library/cortex-shim/Chart.yaml:6
- Changing appVersion without bumping the chart
versionmeans downstream charts that depend oncortex-shim(e.g.helm/bundles/cortex-placement-shim/Chart.yaml:12-14pinsversion: 0.1.18) will not receive the new image tag via a new chart artifact. Bump the chart version (and update dependents) to make the update consumable from the OCI chart repo.
version: 0.1.18
appVersion: "sha-10eb153c"
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
99ff8cb to
49e3552
Compare
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changes are limited to Helm chart appVersion bumps and are consistent with the PR description.
Review effort: Lite
Findings: 2
Open (4)
49e3552 to
207cedd
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Two charts are missing the repo-standard SPDX header and the charts’ versions are not bumped despite Chart.yaml content changes, which can break or confuse chart publishing/consumption workflows.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 3
Open (5)
bumped cortex: sha-83e5f5ec -> sha-d4309076 bumped cortex-shim: sha-fa2a5caa -> sha-d4309076 bumped cortex-postgres: sha-83e5f5ec -> sha-f3d9a8b4 Signed-off-by: umswmayj <140147670+umswmayj@users.noreply.github.com>
207cedd to
40c3d75
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The charts’ version fields (and bundle dependency pins) are not bumped, which can prevent consumers from receiving the updated appVersion via normal Helm versioned upgrades.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
Resolved since last review (5)
| version: 0.1.18 | ||
| appVersion: "sha-fa2a5caa" | ||
| appVersion: "sha-d4309076" |
| version: 0.4.3 | ||
| appVersion: "sha-83e5f5ec" | ||
| appVersion: "sha-d4309076" |
bump app version [skip ci]