Skip to content

Fix Haskell timeout-cputime test - #1162

Closed
wil93 wants to merge 1 commit into
cms-dev:masterfrom
wil93:fix_haskell_test
Closed

wil93 wants to merge 1 commit into
cms-dev:masterfrom
wil93:fix_haskell_test

Conversation

@wil93

@wil93 wil93 commented Sep 25, 2020

Copy link
Copy Markdown
Member

This PR should (hopefully) fix the error in the Travis logs


This change is Reviewable

@andreyv

andreyv commented Sep 25, 2020

Copy link
Copy Markdown
Member

Looks like the test now fails even with the old Ubuntu version.

@wil93

wil93 commented Sep 25, 2020

Copy link
Copy Markdown
Member Author

Yeah 😕 we're looking into it

@andreyv

andreyv commented Sep 25, 2020

Copy link
Copy Markdown
Member

FWIW, I can't reproduce the failure on a local Ubuntu 18.04 installation. I'll continue later on my side.

I noticed that the program maps 1 TB of virtual memory, which may (or may not) be relevant.

@codecov

codecov Bot commented Sep 25, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1162 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1162      +/-   ##
==========================================
- Coverage   61.99%   61.97%   -0.03%     
==========================================
  Files         230      230              
  Lines       16604    16604              
==========================================
- Hits        10294    10290       -4     
- Misses       6310     6314       +4     
Flag Coverage Δ
#functionaltests 45.69% <ø> (+0.10%) ⬆️
#unittests 43.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cms/service/ProxyService.py 57.44% <0.00%> (-1.60%) ⬇️
cms/grading/scoring.py 75.58% <0.00%> (-1.17%) ⬇️
cms/db/base.py 82.97% <0.00%> (-1.07%) ⬇️
cms/service/EvaluationService.py 66.48% <0.00%> (-1.07%) ⬇️
cms/server/admin/handlers/base.py 66.77% <0.00%> (-1.02%) ⬇️
cms/io/rpc.py 90.44% <0.00%> (-0.69%) ⬇️
cms/service/esoperations.py 78.72% <0.00%> (ø)
cms/db/filecacher.py 77.37% <0.00%> (+0.32%) ⬆️
cms/service/workerpool.py 62.22% <0.00%> (+0.55%) ⬆️
cms/grading/Sandbox.py 68.59% <0.00%> (+0.72%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4c9e92...0b1806d. Read the comment docs.

@wil93

wil93 commented Sep 25, 2020

Copy link
Copy Markdown
Member Author

It should work now! I rebased the right commit on top of master.

@andreyv

andreyv commented Sep 26, 2020

Copy link
Copy Markdown
Member

Thanks :) Now it also works with Ubuntu 18.04.

@andreyv andreyv closed this Sep 26, 2020
@andreyv andreyv reopened this Sep 26, 2020
@andreyv

andreyv commented Sep 26, 2020

Copy link
Copy Markdown
Member

Merged in fe15f91.

@andreyv andreyv closed this Sep 26, 2020
@wil93
wil93 deleted the fix_haskell_test branch September 26, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants