Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
|
||
| func (c *PrivateKey) Import(key []byte) bool { | ||
| if len(key) < len(c.e) { | ||
| if len(key) != len(c.e) { |
There was a problem hiding this comment.
🟨 Private key import accepts out-of-range exponents
PrivateKey.Import now enforces the exact byte length but still copies the raw bytes into the exponent array without validating that each 4-bit exponent lies in the documented range [-5, 5] (dh/csidh/csidh.go:199-207, exponents documented at dh/csidh/csidh.go:38-40). A caller importing attacker-supplied or corrupted key material can therefore obtain a private key whose exponents (up to -8..7 after sign extension) are outside the cSIDH/512 parameter set, producing group-action results that are not valid cSIDH secrets while Import still reports success.
Was this helpful? React with 👍 or 👎 to provide feedback.
cjpatton
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.