Skip to content

dh/sidh: document Import() side-effect for kem/sike. #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bwesterb merged 1 commit into from
Jul 18, 2026
+2 −1
Merged

dh/sidh: document Import() side-effect for kem/sike. #662

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dh/sidh/sidh.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ func NewPublicKey(id uint8, v KeyVariant) *PublicKey {

// Import clears content of the public key currently stored in the structure
// and imports key stored in the byte string. Returns error in case byte string
// size is wrong. Doesn't perform any validation.
// size is wrong. Doesn't perform any validation. In particular, sikep434,
// sikep503, and sikep751 all accept non-canonical encoding of field elements.
func (pub *PublicKey) Import(input []byte) error {
if len(input) != pub.Size() {
return errors.New("sidh: input to short")
Expand Down
Loading