feat(types): export OnProxyEvent type - #1263
Conversation
📝 WalkthroughWalkthroughThe ChangesPublic Type Export
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Adding types per "on" event (as the types are now part of OnProxyEvent) & exposing those would even be better, but not sure if that's fine |
commit: |
|
Thanks for the PR. Makes sense to export If you need the individual types from the OnProxyEvent fields, you can use |
Description
Expose OnProxyEvent type
Motivation and Context
We have some OnProxyEvent handlers we build in a sperate file and now need to use
NonNullable<Options<Request, Response>['on']>for the types. This would make it slightly easierHow has this been tested?
Types of changes
Checklist:
Summary by CodeRabbit
OnProxyEventtype is now exported and available for public use.