Repository navigation
Conversation
Allow .s/.S, .ld and .lds files and add asm.md and linker_script.md rules, with *lds.s mapped to the linker rule ahead of **/*.s. Refs alibaba#1243, alibaba#470. Signed-off-by: ChethanUK <chethanuk@outlook.com>
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 38 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (11)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
User descriptionDescriptionAssembly ( Changes:
It appends to the same tail lines as the devicetree PR (#42, not in upstream yet), so the two will conflict trivially. Whichever lands second needs a rebase. Type of Change
How Has This Been Tested?New allowlist and rule-matching table rows fail before the change and pass after it.
Known limits:
Checklist
Claude (Anthropic) drafted the change and this description. I reviewed all of it and will answer review comments myself. Related IssuesRefs alibaba#1243 CodeAnt-AI DescriptionAdd review coverage for assembly and linker script files What Changed
Impact
💡 Usage GuideChecking Your Pull RequestEvery time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later. Talking to CodeAnt AIGot a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask: This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code. ExamplePreserve Org Learnings with CodeAntYou can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input: This helps CodeAnt AI learn and adapt to your team's coding style and standards. ExampleRetrigger reviewAsk CodeAnt AI to review the PR again, by typing: Check Your Repository HealthTo analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health. |
CodeAnt Nitpicks2 code suggestions1. The
|
…n lds.s **/*lds.s also routed builds.s and fields.S to linker_script.md. **/*[.]lds.s requires the dot, so vmlinux.lds.S still resolves to the linker rule (the integrity test's globExt skips it as it has no '*.' prefix). Table rows added. Signed-off-by: ChethanUK <chethanuk@outlook.com>
Description
Assembly (
.s,.S) and linker script (.ld,.lds) files are dropped by the extension allowlist, so they never reach review. Part of alibaba#1243 (kernel/BSP code review, under alibaba#470).Changes:
.s,.S,.ldand.ldstosupported_file_types.json.system_rules.json, route**/*.{ld,lds}and**/*[.]lds.stolinker_script.md, ahead of**/*.stoasm.md, sovmlinux.lds.Sgets the linker rule. The[.]keeps names such asbuilds.son the assembly rule.asm.mdandlinker_script.mdrule docs.review-rules.md.It appends to the same tail lines as the devicetree PR (#42, not in upstream yet), so the two conflict trivially. Whichever lands second needs a rebase.
Type of Change
How Has This Been Tested?
New allowlist and rule-matching table rows fail before the change and pass after it, including rows that keep
builds.s,fields.Sandlds.son the assembly rule.make testpasses locallygo test -race ./...andmake checkpass. In a scratch repo,delegate previewonentry.S,vmlinux.lds.Sandboard/link.ldreportsreviewable_count 3,excluded 0. With--exclude 'arch/**'onlyboard/link.ldstays reviewable.Known limits:
*.lds.sstill gets the linker rule. The docs tell the reviewer to skip linker checks when the file has no linker content.Checklist
go fmt,go vet)Claude (Anthropic) drafted the change and this description. I reviewed all of it and will answer review comments myself.
Related Issues
Refs alibaba#1243