Skip to content

fix(i18n): restore Turkish memories description key - #3940

Open
fitzgpt wants to merge 1 commit into
chatboxai:mainfrom
fitzgpt:fix/tr-memories-facts-key
Open

fitzgpt wants to merge 1 commit into
chatboxai:mainfrom
fitzgpt:fix/tr-memories-facts-key

Conversation

@fitzgpt

@fitzgpt fitzgpt commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

What

The Turkish translation for the Memories description stopped matching its source string and now falls back to English in the Turkish UI.

The English key changed in v1.23.0 (#1008) to:

Facts the agent saved from your conversations. They are loaded into new agent sessions; deleting one only affects future sessions.

but the later Turkish terminology polish pass keyed the entry to the older wording (Facts saved from your conversations...), which no longer exists in en/translation.json. Turkish is the only locale missing this key — de, fr, es, ja, ko, ru all have it.

Change

  • Re-key the entry to the current English source string and restore the agent-session wording in the translation.
  • The stray HarmonyOS Local Model entry is left untouched — it looks like a deliberate sync from the pro tree and an extra key is harmless.

Validation

  • en vs tr key diff after the change: 0 missing (was 1 missing / 1 orphan).
  • JSON parses cleanly; single-line change in tr/translation.json.

Contributor Agreement

By submitting this Pull Request, I confirm that I have read and agree to the following terms:

  • I agree to contribute all code submitted in this PR to the open-source community edition licensed under GPLv3 and the proprietary official edition without compensation.
  • I grant the official edition development team the rights to freely use, modify, and distribute this code, including for commercial purposes.
  • I confirm that this code is my original work, or I have obtained the appropriate authorization from the copyright holder to submit this code under these terms.
  • I understand that the submitted code will be publicly released under the GPLv3 license, and may also be used in the proprietary official edition.

Please check the box below to confirm:

  • I have read and agree with the above statement.

@coderabbitai

coderabbitai Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 392848b3-af76-475c-ae0f-92a9354385f8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The Turkish memories description was keyed to 'Facts saved from your conversations...' while the English source string is 'Facts the agent saved from your conversations. They are loaded into new agent sessions; deleting one only affects future sessions.' (changed in v1.23.0), so the translation stopped matching and the UI fell back to English. Re-key the entry to the current source string and keep the agent-session wording in the translation.
@fitzgpt
fitzgpt force-pushed the fix/tr-memories-facts-key branch from 1e9a9ff to 67e29ba Compare September 19, 2026 11:06
@themez

themez commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

please include this agreement in your pr description and check it

### Contributor Agreement

By submitting this Pull Request, I confirm that I have read and agree to the following terms:

- I agree to contribute all code submitted in this PR to the open-source community edition licensed under GPLv3 and the proprietary official edition without compensation.
- I grant the official edition development team the rights to freely use, modify, and distribute this code, including for commercial purposes.
- I confirm that this code is my original work, or I have obtained the appropriate authorization from the copyright holder to submit this code under these terms.
- I understand that the submitted code will be publicly released under the GPLv3 license, and may also be used in the proprietary official edition.

**Please check the box below to confirm:**

[ ] I have read and agree with the above statement.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants