Repository navigation
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The Turkish memories description was keyed to 'Facts saved from your conversations...' while the English source string is 'Facts the agent saved from your conversations. They are loaded into new agent sessions; deleting one only affects future sessions.' (changed in v1.23.0), so the translation stopped matching and the UI fell back to English. Re-key the entry to the current source string and keep the agent-session wording in the translation.
fitzgpt
force-pushed
the
fix/tr-memories-facts-key
branch
from
September 19, 2026 11:06
1e9a9ff to
67e29ba
Compare
Contributor
|
please include this agreement in your pr description and check it |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Turkish translation for the Memories description stopped matching its source string and now falls back to English in the Turkish UI.
The English key changed in v1.23.0 (#1008) to:
Facts the agent saved from your conversations. They are loaded into new agent sessions; deleting one only affects future sessions.but the later Turkish terminology polish pass keyed the entry to the older wording (
Facts saved from your conversations...), which no longer exists inen/translation.json. Turkish is the only locale missing this key — de, fr, es, ja, ko, ru all have it.Change
HarmonyOS Local Modelentry is left untouched — it looks like a deliberate sync from the pro tree and an extra key is harmless.Validation
envstrkey diff after the change: 0 missing (was 1 missing / 1 orphan).tr/translation.json.Contributor Agreement
By submitting this Pull Request, I confirm that I have read and agree to the following terms:
Please check the box below to confirm: