Repository navigation
Conversation
An object in an options array also got the array itself as a scope, so it exposed the array's indexes and length as its own options. A plugin that reads such an option and passes it back in doubles the data every round.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11438
An object inside an options array also got the array itself as a scope, so it exposed the array's indexes and
lengthas its own options._resolveArrayalready filters the array out, butaddScopesadded it back through the key lookup.addScopesnow skips arrays.Running the flow from the issue, where a plugin hands its array option back and it gets passed in again, the option's JSON went from 83 to 491,483 bytes over 12 rounds, and each round from 2.6 to 233.1 ms. With the fix it stays at 23 bytes and about 2 ms.