Skip to content

Split git tag and github release options - #680

Merged
Andarist merged 5 commits into
mainfrom
git-tag-release-option
Jul 1, 2026
Merged

Split git tag and github release options#680
Andarist merged 5 commits into
mainfrom
git-tag-release-option

Conversation

@bluwy

@bluwy bluwy commented Jun 29, 2026

Copy link
Copy Markdown
Member

fix #247
fix #547

NOTE: the above issues requested documentation improvements, but I have not done them here yet. I think probably it's easiest to consolidate all the docs update once we've finished reworking the actions & sub-actions.

Possible alternatives

1. I wonder if it should be push-git-tags instead of create-git-tags, because we'd actually only do the pushing. (renamed)

  1. This is a breaking change because create-github-releases: false previously also disabled push tags, but now it'd push by default, unless set push-git-tags: true explicitly.

    We can kinda prevent this breaking change by making push-git-tags always follow the value of create-github-releases, unless push-git-tags was explicitly set, but I feel it's a bit hard to follow compared to the current behaviour, where both are independent options, just that create-github-releases: true will always force push-git-tags: true because inherently that's how github releases work.

    Or we support some sort of create-github-releases: "tag-only" but this also seems a bit weird.

@bluwy
bluwy requested review from Andarist and emmatown as code owners June 29, 2026 02:35
@changeset-bot

changeset-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 39422af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@changesets/action Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread action.yml Outdated
Comment thread .changeset/chubby-geese-sink.md Outdated

@trueberryless trueberryless left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. Changes look good to me, the logic seems fine. Description matches the behaviour.

Do we have any tests yet for the actions?

@bluwy

bluwy commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

Our tests currently is very loose. We should get to that after we're finished with most of the big changes I think.

@Andarist
Andarist added this pull request to the merge queue Jul 1, 2026
Merged via the queue into main with commit ca57073 Jul 1, 2026
7 checks passed
@Andarist
Andarist deleted the git-tag-release-option branch July 1, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

createGithubReleases: false disables git tag pushes too which is undocumented support disable push tags

3 participants