Skip to content

Avoid putting the github token in the global .netrc file - #670

Merged
Andarist merged 2 commits into
mainfrom
fix/version-subaction-auth
Jun 24, 2026
Merged

Avoid putting the github token in the global .netrc file#670
Andarist merged 2 commits into
mainfrom
fix/version-subaction-auth

Conversation

@Andarist

Copy link
Copy Markdown
Member

No description provided.

@Andarist
Andarist requested review from beeequeue and bluwy June 24, 2026 09:30
@changeset-bot

changeset-bot Bot commented Jun 24, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: db79192

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@changesets/action Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread .changeset/git-cli-server-url.md Outdated
Comment thread src/github.ts
readonly #githubToken: string;
readonly octokit: Octokit;
readonly cwd: string;
readonly commitMode: CommitMode;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this just be called mode instead? it affects more than just commits

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can rename it here but I wouldn't like to touch the public option in this PR - and those 2 are the same thing so keeping the name consistent makes it easier to reason about. That said, I agree it's not a particularly accurate name

@Andarist
Andarist requested a review from beeequeue June 24, 2026 10:05
@Andarist
Andarist added this pull request to the merge queue Jun 24, 2026
Merged via the queue into main with commit 5a8b9b7 Jun 24, 2026
7 checks passed
@Andarist
Andarist deleted the fix/version-subaction-auth branch June 24, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants