-
-
Notifications
You must be signed in to change notification settings - Fork 406
Rename to kebab-case for root action inputs and outputs #668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@changesets/action": major | ||
| --- | ||
|
|
||
| Rename the input and output names to kebab-case instead of camelCase to match the official GitHub actions pattern |
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -21,15 +21,15 @@ inputs: | |||
| title: | ||||
| description: The pull request title. Default to `Version Packages` | ||||
| required: false | ||||
| setupGitUser: | ||||
| setup-git-user: | ||||
| description: Sets up the git user for commits as `"github-actions[bot]"`. Default to `true` | ||||
| required: false | ||||
| default: true | ||||
| createGithubReleases: | ||||
| create-github-releases: | ||||
| description: "A boolean value to indicate whether to create Github releases after `publish` or not" | ||||
| required: false | ||||
| default: true | ||||
| commitMode: | ||||
| commit-mode: | ||||
| description: > | ||||
| An enum to specify the commit mode. Use "git-cli" to push changes using the Git CLI, | ||||
| or "github-api" to push changes via the GitHub API. When using "github-api", | ||||
|
|
@@ -40,18 +40,18 @@ inputs: | |||
| branch: | ||||
| description: Sets the branch in which the action will run. Default to `github.ref_name` if not provided | ||||
| required: false | ||||
| prDraft: | ||||
| pr-draft: | ||||
| description: 'Controls draft PR behavior. Use "create" to create new version PRs as draft, or "always" to also convert existing version PRs back to draft when updating them.' | ||||
| required: false | ||||
| outputs: | ||||
| published: | ||||
| description: A boolean value to indicate whether a publishing is happened or not | ||||
| publishedPackages: | ||||
| published-packages: | ||||
| description: > | ||||
| A JSON array to present the published packages. The format is `[{"name": "@xx/xx", "version": "1.2.0"}, {"name": "@xx/xy", "version": "0.8.9"}]` | ||||
| hasChangesets: | ||||
| has-changesets: | ||||
| description: A boolean about whether there were changesets. Useful if you want to create your own publishing functionality. | ||||
| pullRequestNumber: | ||||
| pull-request-number: | ||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. that's note that it's also missing in the declared Line 40 in a35a66b
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah we should align the names eventually. In this PR I'd like to focus on kebab-casing only |
||||
| description: The pull request number that was created or updated | ||||
| branding: | ||||
| icon: "package" | ||||
|
|
||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@beeequeue noticed (rightfully so) this isn't exactly tightly-coupled to committing. But I'm not sure if we have the appetitete to rename this stuff right now