Repository navigation
Add Redis Cluster transport (rediscluster://) - #2838
Open
daveisfera wants to merge 3 commits into
Open
daveisfera wants to merge 3 commits into
daveisfera wants to merge 3 commits into
Conversation
Port and finish the rediscluster broker transport from celery#2204 on current main: TLS via redisclusters://, master→replica UNBLOCKED recovery, redis-py 8 pipeline compatibility, and a tox/CI env that re-runs the existing Redis integration suite against a single-node cluster (REDIS_CLUSTER=1). Supersedes celery#2204. Complements celery/celery#11058 (result backend). Co-authored-by: Cursor <cursoragent@cursor.com>
Upstream kombu redis transport tests use in-process fakes and Mock the same way; keep that seam for rediscluster and rely on REDIS_CLUSTER integration for the real boundary. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
auvipy
self-requested a review
November 10, 2026 17:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rediscluster:///redisclusters://broker transport (ported from support redis cluster transport #2204 onto currentmain), with TLS URL support, master→replicaUNBLOCKEDrecovery, and redis-py 8 pipeline compatibility.integration-redis-clusterre-runs the existing@pytest.mark.env('redis')suite against a single-node Redis Cluster viaREDIS_CLUSTER=1(same approach as Support Redis Cluster in the Redis result backend celery#11058 for the result backend).redis.pycan be a follow-up if maintainers prefer.Test plan
pytest t/unit/transport/test_rediscluster.py(60 passed)REDIS_CLUSTER=1integration suite against local single-node cluster (52 passed, standalone-only cases skipped)py-redis+py-redis-clusterintegration jobs greenRefs: #2204, celery/celery#11058
Made with Cursor