Repository navigation
Redis: refresh binding deadline without ZADD GT (#2819) - #2820
Open
thelastbackspace wants to merge 2 commits into
Open
thelastbackspace wants to merge 2 commits into
thelastbackspace wants to merge 2 commits into
Conversation
ZADD GT needs Redis 6.2, so REFRESH_BINDING failed with a syntax error on Redis 6.0 and broke every consumer of an x-expires queue. Compare against the current score in Lua instead.
auvipy
self-requested a review
November 10, 2026 15:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since 5.7.0 the
REFRESH_BINDINGLua script callsZADD ... GT. GT only exists from Redis 6.2, so on 6.0 (still what Azure Cache for Redis runs) the script fails withERR syntax errorand any consumer of anx-expiresqueue breaks, e.g. the Celery pidbox queue at worker startup.Fix
I replaced the GT flag with a
ZSCORE+ compare in the script, so the deadline is still only ever raised, never lowered. Works on any Redis with scripting.Testing
Added unit tests that run the real script through lupa against a stub of the Redis 6.0 commands (ZADD rejects flags). They fail on main with
ERR syntax errorand pass with the fix, and also check a later deadline is not lowered. I addedlupatorequirements/test.txtso they don't just skip in CI; happy to drop that and mark them skip-if-missing if you'd rather not add a test dep.Fixes #2819