Skip to content

make sqs basic_reject delete the message from sqs if requeue = false - #2711

Closed
mina58 wants to merge 5 commits into
celery:mainfrom
mina58:implement-sqs-reject-2421
Closed

mina58 wants to merge 5 commits into
celery:mainfrom
mina58:implement-sqs-reject-2421

Conversation

@mina58

@mina58 mina58 commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Overriding basic_reject in SQS channel to ack (basically delete) a message when the requeue option is False. previously the message kept getting backed off.

Fixes #2421

@codecov

codecov Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.47%. Comparing base (2fae7e1) to head (39e49ce).

Files with missing lines Patch % Lines
kombu/transport/SQS/__init__.py 61.11% 3 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2711      +/-   ##
==========================================
- Coverage   85.51%   85.47%   -0.05%     
==========================================
  Files          80       80              
  Lines       11484    11499      +15     
  Branches     1379     1383       +4     
==========================================
+ Hits         9821     9829       +8     
- Misses       1441     1444       +3     
- Partials      222      226       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@auvipy auvipy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test coverage seems to reduce a lot for the patch... can you please improve it? also is the change already covered by existing integration tests of SQS infra?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Celery SQS Consumer Crashes with JSONDecodeError on Invalid / Non-Celery Messages

2 participants