Repository navigation
feat(cli): cli changes to align with rollups-node [upcoming changes] - #529
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 1840fd7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
Coverage Report
📁 File Coverage (20 files)
|
brunomenezes
force-pushed
the
feat/rollups-node-changes
branch
4 times, most recently
from
October 2, 2026 14:25
7a54a60 to
986212c
Compare
Member
|
I don't know if I like the state polling by |
brunomenezes
force-pushed
the
feat/rollups-node-changes
branch
2 times, most recently
from
October 3, 2026 12:42
6218eca to
b805479
Compare
Member
Author
Iteration. If is not good we drop in the coming versions. |
5 of 8 tasks
brunomenezes
force-pushed
the
feat/rollups-node-changes
branch
from
October 5, 2026 09:52
b805479 to
ea69fc4
Compare
…uilderFactory to the address book
brunomenezes
force-pushed
the
feat/rollups-node-changes
branch
from
October 5, 2026 17:40
ea69fc4 to
1840fd7
Compare
brunomenezes
marked this pull request as ready for review
October 5, 2026 17:42
tuler
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns the CLI with rollups-node
2.0.0-alpha.13and rollups-contracts3.0.0-alpha.10/ PRT3.0.0-alpha.5, and moves the default SDK to the released0.12.0-alpha.43.The headline change: a guest exception or machine halt is now a terminal state — the node permanently stops processing inputs for that application, across restarts, while L1 indexing stays alive. So
cartesi sendkeeps succeeding and inputs pile up unprocessed.cartesi runnever re-read application status after deploying, so this was completely silent.Supersedes #520, whose commits are included here.
Features
ApplicationStatuswidened from 4 to the node's 9 values, addingGUEST_EXCEPTION,MACHINE_HALTED,MCYCLE_OVERFLOW,UNEXPECTED_YIELDandINVALID_OUTPUTS_ROOT.cartesi runpolls status and warns the moment an application leavesOK, reporting the node'sreasondiagnostic;cartesi statuscolours terminal states and prints the reason under the table.CARTESI_AUTH_*andCARTESI_PRT_AUTH_*.CARTESI_AUTH_KINDis the one that matters most: without it only plain-mnemonic signing was reachable for the Claimer, since the node picks its signing path from that value alone.TestUsdc,RefundOutputBuilderandUsdWithdrawalOutputBuilderFactory.Fixes
cartesi runsilently skippeddeploy().getMachineHash()passed no image, so it always read snapshots with the default SDK. Against a snapshot written by a newer emulator it returnedundefined, makingcartesi hashreport "snapshot not found" andcartesi runskip deployment with no error at all.--prt.maxTimeout, so a service that never started held the command for up to 19 hours. An exited container now fails fast instead of consuming the budget.--claim-staging-periodwas dropped under--prt. It is a persistent flag on the node's wholedeploycommand, so a value passed alongside--prtwas silently discarded.cartesi depositand fork validation were broken against contracts 3.0.0-alpha.10: renamed portal deposit functions,getInputBoxremoved in favour of probingversion, and the new 6-argumentcalculateDaveAppAddress.Refactoring
@cartesi/devnetto@cartesi/wagmi-plugin, dropping that dependency fromapps/cliand excluding the PRT internals from generation.CI and tooling
0.12.0-alpha.43(cartesi-machine 0.21, rollups-node 2.0.0-alpha.13);requiredVersionnow^0.21.0.cliworkflow —apps/clino longer depends on@cartesi/devnet, so nothing in that job needs forge or anvil.CARTESI_TEST_SDKoverride for verifying against an unreleased image.Verification
Full suite — unit and integration — against the released
0.12.0-alpha.43images with no environment overrides: 184 pass / 1 skip / 0 fail across 15 files. The skip is pre-existing (docker.test.tssqfs drive).tscreports no errors undersrc/.End to end on released artifacts:
cartesi build→cartesi hash→cartesi run→ applicationOK→cartesi address-bookprinting all 17 contracts. The node reports distinct Claimer and PRT signers, which alpha.13 requires.