Repository navigation
Restore compatible Microsoft Extensions package versions - #146
Merged
Merged
Conversation
carndog
marked this pull request as ready for review
November 20, 2026 00:28
carndog
added a commit
that referenced
this pull request
Nov 20, 2026
Restore the OTLP exporter to 1.15.3 and SQL instrumentation to 1.15.2 so the existing Azure Monitor exporter preserves correlated logs. The 1.21.0 OpenTelemetry updates resolve System.Diagnostics.DiagnosticSource 11.0.0. A synthetic .NET 10 probe confirms that recorded root activities then carry Recorded | RandomTraceId. Azure Monitor exporter 1.8.3 uses an exact equality check against Recorded in [LogFilteringProcessor](https://github.com/Azure/azure-sdk-for-net/blob/a1d7cb1acd1dcd1dfd51862e1e5b85d78c88bdd5/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/LogFilteringProcessor.cs), causing those correlated logs to be dropped. The existing Export_WhenLogEmittedWithinSampledActivity_CarriesOperationId test failed on both CI attempts with the updated dependencies. One changed file: Directory.Packages.props. Two package versions change. The SQL client and Testcontainers updates remain. No test assertions, application code or migration changes. Refs #130; follows #146. Validation: - [Full Release build and test workflow](https://github.com/carndog/TradingEngine/actions/runs/44646626572) passed at commit 3b45522. - 1,544 tests passed with no failures or skips: Domain 370, Application 275, Infrastructure 194, Architecture 10, Client 209, API integration 298, SQL infrastructure integration 188. - Build completed with zero warnings and zero errors. - The existing Azure Monitor log-correlation test passes without changes to its assertions. - Solution restore resolves OpenTelemetry SDK 1.15.3 without DiagnosticSource 11. Rollout: keep DEPLOYMENT_HOLD=true until the SignalQuoteLookup migration from #145 has completed. After merging, run Migrate development database from the merged main commit, clear the hold, then run Deploy development from the same commit. Verify the deployed version and report recovery before closing #130.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Microsoft.Extensions.Logging.Console and Microsoft.Extensions.Options.ConfigurationExtensions 11.0.0 updates require transitive dependencies that are centrally pinned to 10.0.15, causing NU1109 restore failures. Return those two packages to 10.0.15 to match the existing dependency line. Keep all five updates from #142.
Refs #130. One changed file: Directory.Packages.props. No application code or migration changes.
Validation:
Rollout: the SignalQuoteLookup migration from #145 must be applied before the matching application runs. Set the repository DEPLOYMENT_HOLD variable to true before merging, run Migrate development database from the merged main commit, then clear the hold and run Deploy development from the same commit. Verify the deployed version and report recovery before closing #130.