Repository navigation
Conversation
…ault
We were experiencing a problem where the h1 text was not being included
in the Readability#content. Here is an example that demonstrates the problem:
```
<article>
<header>
<h1>Title</h1>
</header>
<section>
<p>Paragraph</p>
</section>
</article>
```
Previously, the code would add the <p>, <section> and <article> elements
as @candidates because it adds the parent and grand parent of every <p>. It
would not add the <header> element as a candidate.
Then, the best_candidate with the highest score is the <section> element.
The code then tries to add related siblings in #get_article but it wasn't
adding the <header> element because it wasn't in the list of candidates.
We can solve this problem by adding <h1> to the list of elements to score
which will then ensure that <header> parent is included in the
candidates and can be added as a related sibling.
This commit also adds <pre> to the list of default nodes to score
because it is included in arc90's original code here:
https://github.com/masukomi/arc90-readability/blob/master/js/readability.js#L749
I'm not sure why this was omitted.
Contributor
Author
|
Superseded by #94 which sets a different source branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow passing in an array of elements_to_score and add 'pre' as a default
We were experiencing a problem where the h1 text was not being included
in the Readability#content. Here is an example that demonstrates the problem:
Previously, the code would add the
<p>,<section>and<article>elementsas
@candidatesbecause it adds the parent and grand parent of every<p>. Itwould not add the
<header>element as a candidate.Then, the best_candidate with the highest score is the
<section>element.The code then tries to add related siblings in #get_article but it wasn't
adding the
<header>element because it wasn't in the list of candidates.We can solve this problem by adding
<h1>to the list of elements to scorewhich will then ensure that
<header>parent is included in thecandidates and can be added as a related sibling.
This commit also adds
<pre>to the list of default nodes to scorebecause it is included in arc90's original code here:
https://github.com/masukomi/arc90-readability/blob/master/js/readability.js#L749
I'm not sure why this was omitted.