Repository navigation
fix(create-react-native-library): ignore test app artifacts - #952
dcavalcante wants to merge 1 commit into
Conversation
| # Generated by CocoaPods for the test app. | ||
| example/ios/*.xcworkspace/ | ||
| # Generated by react-native-test-app and contains the local Node path. | ||
| example/ios/.xcode.env |
There was a problem hiding this comment.
these are ignored for all templates but only relevant for test app, and could be important for other templates. e.g. .xcode.env is intended for source control for regular react native apps.
a better approach maybe to keep the example's .gitignore instead of deleting it to keep example specific ignores.
eb10dee to
2491285
Compare
|
Updated to preserve react-native-test-app’s generated |
|
hey @satya164 I updated this to preserve the test app’s generated .gitignore as suggested. The old CI runs are still marked failed, but their logs/jobs have expired. When you have a chance, can you please take another look and rerun the checks? |
Problem
create-react-native-librarygenerates the test app withreact-native-test-app, then removes its generated.gitignore. That loses test-app-specific rules for generated local artifacts.Fix
Preserve the generated
.gitignoreonly for thetest-appexample. Other example flows retain their existing cleanup behavior and manage their own ignore rules where applicable.Validation
example/.gitignore..xcode.envand*.xcworkspace/rules.git diff --check.