fix: apply FuncMap parsers to pointer-to-custom-type fields - #426
Open
Solaris-star wants to merge 1 commit into
Open
fix: apply FuncMap parsers to pointer-to-custom-type fields#426Solaris-star wants to merge 1 commit into
Solaris-star wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a field is a pointer to a custom struct type and has its own
envtag,doParseFieldalways recursed into nested fields and never appliedFuncMapparsers /setFieldfor that pointer field.That made this fail:
Fookept its pre-parse value instead of being rebuilt from the env string.Fix
doParseField, only recurse into*Structwhen the field has no own env key (and field-name defaulting is off). Own keys fall through tosetField.set, allocate a nil pointer target before writing a custom-parser value (soNilFoo *fooworks too).Test plan
TestCustomParserPointerToCustomType(includes nestedOther *bar+ nil pointer target)go test .(with ambientPORTunset)Fixes #385