Adjust fuel consumption to be empty when fuel is at 0 rather than 1 - #5013
Merged
Conversation
Subscribe to Label Actioncc @fitzgen, @peterhuene DetailsThis issue or pull request has been labeled: "fuzzing", "wasmtime:api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Co-authored-by: Jamey Sharp <jsharp@fastly.com>
itsrainy
force-pushed
the
rainy/minor-fuel-changes
branch
from
October 4, 2022 23:34
eebbda2 to
48b7bb9
Compare
alexcrichton
approved these changes
Oct 5, 2022
alexcrichton
left a comment
Member
There was a problem hiding this comment.
Seems reasonable to me, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into this when attempting to use
set_fuelin a fuzz target (bytecodealliance/wasm-tools#769).set_fuelcallsconsume_fuel(0)in order to get the current amount of fuel in a Store. However,consume_fuel(0)will return an out of fuel error if there is 0 fuel remaining, which is the case with a new Store.Switching the
<to a<=also has the effect of making this work:previously this would have returned an "out of fuel" error, which doesn't seem correct, though maybe there's some nuance I'm missing?