[AArch64] Fix incorrect regalloc constraints for atomic_cas - #4959
Merged
Conversation
github-actions
Bot
added
cranelift
Contributor
Author
|
The first commit can be directly applied against the release-1.0.0 branch. The commit after that blesses the test for the current main branch. |
cfallin
approved these changes
Sep 26, 2022
cfallin
left a comment
cfallin
left a comment
Member
There was a problem hiding this comment.
Thanks a bunch for the debugging effort here! This will make it for 2.0 for sure and I'll see about a patch release for 1.0 as well.
cfallin
enabled auto-merge (squash)
September 26, 2022 16:04
cfallin
pushed a commit
to cfallin/wasmtime
that referenced
this pull request
Sep 26, 2022
…alliance#4959) * [AArch64] Fix incorrect regalloc constraints for atomic_cas * Update test for latest Cranelift changes
cfallin
added a commit
that referenced
this pull request
Sep 26, 2022
…4960) * [AArch64] Fix incorrect regalloc constraints for atomic_cas (#4959) * [AArch64] Fix incorrect regalloc constraints for atomic_cas * Update test for latest Cranelift changes * Update precise-output test for 1.0.0 regalloc. Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression in Cranelift 0.88.0 that causes cg_clif's test suite to fail on AArch64.