cranelift: Add shifts and extends to fuzzer - #4700
Merged
Merged
Conversation
These were moved to the main shifts file in bytecodealliance#4519 but this file was accidentaly left in tree. It also fixes the missing sshr_i8_i8 testcase
afonso360
force-pushed
the
fuzz-shift-ext
branch
from
August 11, 2022 23:19
d47b52d to
fcda3f6
Compare
github-actions
Bot
added
the
cranelift
jameysharp
approved these changes
Aug 12, 2022
jameysharp
left a comment
jameysharp
left a comment
Contributor
There was a problem hiding this comment.
Ah, all good fixes then!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Hey,
This adds shifts and extends to the fuzzer's op list.
It also de-duplicates some tests (
shifts-small-types.clif) that were accidentally left in tree on #4519.Additionally we had a test (
sshr_i8_i8), that had the wrong signature and results (probably from me copy pasting a bit too much!).cc: @jameysharp